Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renovate + changesets investigation #1493

Open
AaronMoat opened this issue Mar 25, 2024 · 3 comments
Open

Renovate + changesets investigation #1493

AaronMoat opened this issue Mar 25, 2024 · 3 comments
Labels
blocked

Comments

@AaronMoat
Copy link
Contributor

AaronMoat commented Mar 25, 2024 •
edited

Look into:

  • Auto generating changesets for renovates in the skuba repository, so we can't forget to generate one
  • Using gitIgnoredAuthors for the above to not lock the PRs after first commit.
  • Extending gitIgnoredAuthors for the general SEEK ecosystem in combination with skuba autofixes, to not lock renovate PRs after first commit
72636c added a commit to seek-oss/rynovate that referenced this issue Mar 25, 2024
@72636c
Ignore autofix commits for SEEK-Jobs and seek-oss
c37cca0 
The intent here is to allow Renovate to rebase a branch even if it has a
skuba autofix commits that have been pushed. I think this is as simple
as hardcoding the fixed bot accounts that we use for this purpose.

seek-oss/skuba#1493
@72636c 72636c mentioned this issue Mar 25, 2024
Merged
AaronMoat pushed a commit to seek-oss/rynovate that referenced this issue Mar 25, 2024
@72636c
Ignore autofix commits for SEEK-Jobs and seek-oss (#108)
3efa025 
The intent here is to allow Renovate to rebase a branch even if it has a
skuba autofix commits that have been pushed. I think this is as simple
as hardcoding the fixed bot accounts that we use for this purpose.

seek-oss/skuba#1493
@AaronMoat
Copy link
Contributor Author

We can try again when v38 is released: renovatebot/renovate#27992

@samchungy
Copy link
Contributor

Can we delete

skuba/src/cli/lint/autofix.ts

Line 74 in 3310e6e

'An autofix is available, but it was not pushed because an open pull request for this Renovate branch could not be found. If a pull request has since been created, retry the lint step to push the fix.';
if it lands?

@AaronMoat
Copy link
Contributor Author

Ah nice. Yes, likely, though it means that we're relying on users using rynovate* for it to work nicely. Which, maybe is ok

(*unless this makes momentum: seek-oss/renovate-config-seek#21)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AaronMoat @samchungy