Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dialog #3

Open
1 of 3 tasks
secretsauceai opened this issue Dec 30, 2021 · 1 comment
Open
1 of 3 tasks

Refactor dialog #3

secretsauceai opened this issue Dec 30, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@secretsauceai
Copy link
Owner

secretsauceai commented Dec 30, 2021

There are a lot of print statements (and f-string print statements) in the CLI. It has been suggested to pull them out and let them be handled as a dialog JSON file. And it's always fun to handle dialog with slotting (ie NLG).

  • Write a class to handle dialog
  • Move dialog from the flows into a JSON file
  • Test
@secretsauceai secretsauceai added the good first issue Good for newcomers label Feb 23, 2022
@secretsauceai
Copy link
Owner Author

The dialog from get_base_model_flow.py has been moved into dialog.json as an example, however the other flows still have all of their print statements hard coded into the python files. To make it easier to change dialog and to have an overview of the steps, the dialog from all flows should be moved into dialog.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant