Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Azure to recommened preset if it is not false positive #561

Open
azu opened this issue Jul 6, 2023 · 2 comments
Open

Add Azure to recommened preset if it is not false positive #561

azu opened this issue Jul 6, 2023 · 2 comments
Labels
Status: Proposal Request for comments

Comments

@azu
Copy link
Member

azu commented Jul 6, 2023

We want to add Azure to recommened preset in next major version if it is not false positive.

Welcome to feedback
@azu azu added the Status: Proposal Request for comments label Jul 6, 2023
@azu
Copy link
Member Author

azu commented Nov 12, 2023 •
edited

Merge into #680

@azu azu closed this as completed Nov 27, 2023
@azu
Copy link
Member Author

azu commented Nov 28, 2023

https://github.com/secretlint/secretlint/blob/master/packages/%40secretlint/secretlint-rule-azure/README.md#AzureClientId

1234565-cdfb-4f42-aa3c-f00da349dec3

Azure rule detect it but it is not AzureId.

@azu azu reopened this Nov 28, 2023
azu added a commit that referenced this issue Nov 29, 2023
@azu
chore(canary): remove azure from preset
0a605ea 
false positive
#561 (comment)
@azu azu mentioned this issue Nov 29, 2023
Merged
azu added a commit that referenced this issue Nov 29, 2023
@azu
chore(canary): remove azure from preset (#698)
389c86c 
false positive
#561 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Proposal Request for comments
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@azu