Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule: decode Base64 #19

Open
azu opened this issue Feb 11, 2020 · 4 comments
Open

Rule: decode Base64 #19

azu opened this issue Feb 11, 2020 · 4 comments
Labels
Status: Need More Info Lacks enough info to make progress Status: Proposal Request for comments

Comments

@azu
Copy link
Member

azu commented Feb 11, 2020

base64 is not encrypted logic.
We should decode base64 text and check it.
@azu
Copy link
Member Author

azu commented Feb 11, 2020

we need to provide helper?

@azu azu added Status: Need More Info Lacks enough info to make progress Status: Proposal Request for comments labels Feb 12, 2020
@azu
Copy link
Member Author

azu commented Feb 28, 2020

It will be weak-enctrypto rule.

@azu
Copy link
Member Author

azu commented Feb 28, 2020

Enctrypted token may be catched as false-positive.

For example, following token is enctrypted with password. but some rule detect it as raw token.

    AWS_SECRET_ACCESS_KEY: R6WCNd0erkAuZyD+Fe8C4IwjpYQtniKqnHAzE7Pk5fPrBRpwOnuYxA==

@azu
Copy link
Member Author

azu commented Feb 28, 2020

Add little tips https://github.com/secretlint/secretlint/blob/master/docs/secretlint-rule.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Need More Info Lacks enough info to make progress Status: Proposal Request for comments
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@azu