Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the potential dependency on react-redux etc giving warnings #5

Open
sebinsua opened this issue Jan 6, 2018 · 1 comment
Open

Comments

@sebinsua
Copy link
Owner

sebinsua commented Jan 6, 2018

./node_modules/conventional-component/dist/redux.js
Module not found: Error: Can't resolve 'react-redux' in '/Users/sebinsua/Development/react-choices/node_modules/conventional-component/dist'
 @ ./node_modules/conventional-component/dist/redux.js 14:19-41
 @ ./node_modules/conventional-component/dist/asConnectedComponent.js
 @ ./node_modules/conventional-component/dist/index.js
 @ ./index.mjs
 @ ./stories/index.js
 @ ./.storybook/config.js
 @ multi ./node_modules/@storybook/react/dist/server/config/polyfills.js ./node_modules/@storybook/react/dist/server/config/globals.js (webpack)-hot-middleware/client.js?reload=true ./.storybook/config.js

Not that it really matters, as it's been wrapped with a try-catch. But a better solution would be to detach this API from the main package into a conventional-component-redux package (within a lerna monorepo) which can be installed separately if you need this functionality.

@sebinsua
Copy link
Owner Author

sebinsua commented Jan 8, 2018

This is actually quite hard because we need to share the flow and typescript types and must ensure there are no circular dependencies. I think I'm going to need to read flow-copy-source and then to create three packages: conventional-component, conventional-component-redux, conventional-component-core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant