Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove_key not balanced and leave orphan nodes. #5

Open
youtubezou opened this issue Dec 31, 2019 · 1 comment
Open

remove_key not balanced and leave orphan nodes. #5

youtubezou opened this issue Dec 31, 2019 · 1 comment

Comments

@youtubezou
Copy link

testcase:
`static void print_sebrb(t_rbnode *n, int level, int seq)
{
int lvl = level;
if (lvl == 0 && n) {
printf("(%s:%d)\n", n->color ? "RED" : "BLK",
n->key);
} else {
while (--lvl >= 0) {
printf("| ");
}
printf("|---%s", seq ? "R" : "L");
if (!n) {
printf("(BLK, null)\n");
return ;
} else {
printf("(%s:%d)\n",
n->color ? "RED" : "BLK",
n->key);
}
}
if (n) {
print_sebrb(n->left, level + 1, 0);
print_sebrb(n->right, level + 1, 1);
}
}

TESTCASE(rbtree, ut_sebrbtree)
{
extern t_rbnode *root_rbtree;
int i;
int data[] = {
40, 30, 20, 50, 60, 55, 4, 24, 80, 33, 44, 11
};
int size = ARRAY_CNT(data);
t_rbnode *nodes = malloc(size * sizeof(t_rbnode));
t_rbnode *node;

srand(time(NULL));

for (i = 0; i < ARRAY_CNT(data); i++) {
    insert(data[i], data[i]);
}

{
    print_sebrb(root_rbtree, 0, 0);
    for (i = 0; i < size; i++) {
        LOG_DEBUG("delete-inorder:%d", data[i]);
        root_rbtree = remove_key(root_rbtree, data[i]);
        print_sebrb(root_rbtree, 0, 0);
        //map->dump(map);
        //map->dump(map);
    }
}
erase_tree(root_rbtree);
return 1;

}

`

@youtubezou
Copy link
Author

Result:
(BLK:50)
| |---L(RED:30)
| | |---L(BLK:20)
| | | |---L(BLK:11)
| | | | |---L(RED:4)
| | | | | |---L(BLK, null)
| | | | | |---R(BLK, null)
| | | | |---R(BLK, null)
| | | |---R(BLK:24)
| | | | |---L(BLK, null)
| | | | |---R(BLK, null)
| | |---R(BLK:40)
| | | |---L(BLK:33)
| | | | |---L(BLK, null)
| | | | |---R(BLK, null)
| | | |---R(BLK:44)
| | | | |---L(BLK, null)
| | | | |---R(BLK, null)
| |---R(BLK:60)
| | |---L(BLK:55)
| | | |---L(BLK, null)
| | | |---R(BLK, null)
| | |---R(BLK:80)
| | | |---L(BLK, null)
| | | |---R(BLK, null)
ut_sebrbtree(156)-> "delete-inorder:40"
(BLK:50)
| |---L(BLK:30)
| | |---L(RED:20)
| | | |---L(BLK:11)
| | | | |---L(RED:4)
| | | | | |---L(BLK, null)
| | | | | |---R(BLK, null)
| | | | |---R(BLK, null)
| | | |---R(BLK:24)
| | | | |---L(BLK, null)
| | | | |---R(BLK, null)
| | |---R(BLK:44)
| | | |---L(RED:33)
| | | | |---L(BLK, null)
| | | | |---R(BLK, null)
| | | |---R(BLK, null)
| |---R(BLK:60)
| | |---L(BLK:55)
| | | |---L(BLK, null)
| | | |---R(BLK, null)
| | |---R(BLK:80)
| | | |---L(BLK, null)
| | | |---R(BLK, null)
ut_sebrbtree(156)-> "delete-inorder:30"
(BLK:50)
| |---L(BLK:20)
| | |---L(BLK:11)
| | | |---L(RED:4)
| | | | |---L(BLK, null)
| | | | |---R(BLK, null)
| | | |---R(BLK, null)
| | |---R(BLK:33)
| | | |---L(BLK:24)
| | | | |---L(BLK, null)
| | | | |---R(BLK, null)
| | | |---R(BLK:44)
| | | | |---L(BLK, null)
| | | | |---R(BLK, null)
| |---R(BLK:60)
| | |---L(BLK:55)
| | | |---L(BLK, null)
| | | |---R(BLK, null)
| | |---R(BLK:80)
| | | |---L(BLK, null)
| | | |---R(BLK, null)
ut_sebrbtree(156)-> "delete-inorder:20"
(BLK:60)
| |---L(RED:50)
| | |---L(BLK:11)
| | | |---L(BLK:4)
| | | | |---L(BLK, null)
| | | | |---R(BLK, null)
| | | |---R(BLK:24)
| | | | |---L(BLK, null)
| | | | |---R(BLK:44)
| | | | | |---L(RED:33)
| | | | | | |---L(BLK, null)
| | | | | | |---R(BLK, null)
| | | | | |---R(BLK, null)
| | |---R(BLK:55)
| | | |---L(BLK, null)
| | | |---R(BLK, null)
| |---R(BLK:80)
| | |---L(BLK, null)
| | |---R(BLK, null)
ut_sebrbtree(156)-> "delete-inorder:50"
(BLK:60)
| |---L(BLK:55)
| | |---L(RED:11)
| | | |---L(BLK:4)
| | | | |---L(BLK, null)
| | | | |---R(BLK, null)
| | | |---R(BLK:24)
| | | | |---L(BLK, null)
| | | | |---R(BLK:44)
| | | | | |---L(RED:33)
| | | | | | |---L(BLK, null)
| | | | | | |---R(BLK, null)
| | | | | |---R(BLK, null)
| | |---R(BLK, null)
| |---R(BLK:80)
| | |---L(BLK, null)
| | |---R(BLK, null)
ut_sebrbtree(156)-> "delete-inorder:60"
(BLK:55)
| |---L(BLK:11)
| | |---L(BLK:4)
| | | |---L(BLK, null)
| | | |---R(BLK, null)
| | |---R(BLK:24)
| | | |---L(BLK, null)
| | | |---R(BLK:44)
| | | | |---L(RED:33)
| | | | | |---L(BLK, null)
| | | | | |---R(BLK, null)
| | | | |---R(BLK, null)
| |---R(BLK:80)
| | |---L(BLK, null)
| | |---R(BLK, null)
ut_sebrbtree(156)-> "delete-inorder:55"
(BLK:80)
| |---L(RED:11)
| | |---L(BLK:4)
| | | |---L(BLK, null)
| | | |---R(BLK, null)
| | |---R(BLK:24)
| | | |---L(BLK, null)
| | | |---R(BLK:44)
| | | | |---L(RED:33)
| | | | | |---L(BLK, null)
| | | | | |---R(BLK, null)
| | | | |---R(BLK, null)
| |---R(BLK, null)
ut_sebrbtree(156)-> "delete-inorder:4"
(BLK:80)
| |---L(BLK:24)
| | |---L(RED:11)
| | | |---L(BLK, null)
| | | |---R(BLK, null)
| | |---R(BLK:44)
| | | |---L(RED:33)
| | | | |---L(BLK, null)
| | | | |---R(BLK, null)
| | | |---R(BLK, null)
| |---R(BLK, null)
ut_sebrbtree(156)-> "delete-inorder:24" -- not balanced.
(BLK:80)
| |---L(BLK:11)
| | |---L(BLK, null)
| | |---R(BLK:33)
| | | |---L(BLK, null)
| | | |---R(BLK:44)
| | | | |---L(BLK, null)
| | | | |---R(BLK, null)
| |---R(BLK, null)
ut_sebrbtree(156)-> "delete-inorder:80" -- leave orphan
|---L(BLK, null)
ut_sebrbtree(156)-> "delete-inorder:33"
|---L(BLK, null)
ut_sebrbtree(156)-> "delete-inorder:44"
|---L(BLK, null)
ut_sebrbtree(156)-> "delete-inorder:11"
|---L(BLK, null)**

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant