Setup SDK generator #79
Conversation
… setup-for-sdk-generator
There was a problem hiding this comment.
Looks good, can we document in the README how to install the non-generated legacy version. This way we can tell customers to revert to it if there's an issue (since we dont have semantic versioning with php).
For the workflow we might want to just remove the conditional check and see if it causes a loop, maybe it won't 🤷
I noticed SeamError was removed, is that problematic? Maybe it just got moved? Worried about error handling for existing code
| echo "Generating PHP SDK..." | ||
| else | ||
| echo "No 'autorelease' keyword found. Skipping PHP SDK generation." | ||
| exit 0 |
There was a problem hiding this comment.
This wont stop the workflow i think, it'll continue to the next step (I think? Exit 0 means exit with success) you also cant error out, so there must be a different way
|
Was merged into https://github.com/seamapi/generated-php |
Closes #78