{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":28449431,"defaultBranch":"master","name":"scylladb","ownerLogin":"scylladb","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-12-24T13:16:33.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/14364730?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714548089.0","currentOid":""},"activityList":{"items":[{"before":"e0d597348b64aefe4101a31437a33a7e0351aaf8","after":"53b98a86105cd241505267e1044a65a85945d01a","ref":"refs/heads/master","pushedAt":"2024-05-03T14:58:04.000Z","pushType":"push","commitsCount":24,"pusher":{"login":"scylladb-promoter","name":null,"path":"/scylladb-promoter","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/36883350?s=80&v=4"},"commit":{"message":"test: string_format_test: disable test if {fmt} >= 10.0.0\n\n{fmt} v10.0.0 introduces formatter for `std::optional`, so there\nis no need to test it. furthermore the behavior of this formatter\nis different from our homebrew one. so let's skip this test if\n{fmt} v10.0.0 or up is used.\n\nRefs #18508\n\nSigned-off-by: Kefu Chai <kefu.chai@scylladb.com>\n\nCloses scylladb/scylladb#18509","shortMessageHtmlLink":"test: string_format_test: disable test if {fmt} &gt;= 10.0.0"}},{"before":"3421e6dcc1a3d7e85a1c99f7a5210364bca54284","after":"53b98a86105cd241505267e1044a65a85945d01a","ref":"refs/heads/next","pushedAt":"2024-05-03T08:34:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"avikivity","name":"Avi Kivity","path":"/avikivity","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1017210?s=80&v=4"},"commit":{"message":"test: string_format_test: disable test if {fmt} >= 10.0.0\n\n{fmt} v10.0.0 introduces formatter for `std::optional`, so there\nis no need to test it. furthermore the behavior of this formatter\nis different from our homebrew one. so let's skip this test if\n{fmt} v10.0.0 or up is used.\n\nRefs #18508\n\nSigned-off-by: Kefu Chai <kefu.chai@scylladb.com>\n\nCloses scylladb/scylladb#18509","shortMessageHtmlLink":"test: string_format_test: disable test if {fmt} &gt;= 10.0.0"}},{"before":"8de81f8f913bfa1809b45a295a6cc347a1083d7d","after":"3421e6dcc1a3d7e85a1c99f7a5210364bca54284","ref":"refs/heads/next","pushedAt":"2024-05-02T20:26:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"avikivity","name":"Avi Kivity","path":"/avikivity","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1017210?s=80&v=4"},"commit":{"message":"tools/scylla-nodetool: add formatter for char*\n\nin {fmt} version 10.0.0, it has a regression, which dropped the\nformatter for `char *`, even it does format `const char*`, as the\nlatter is convertible to\n`fmt::stirng_view`.\n\nand this issue was addressed in 10.1.0 using 616a4937, which adds\nthe formatter for `Char *` back, where `Char` is a template parameter.\n\nbut we do need to print `vector<char*>`, so, to address the build\nfailure with {fmt} version 10.0.0, which is shipped along with\nfedora 39. let's backport this formatter.\n\nFixes #18503\nSigned-off-by: Kefu Chai <kefu.chai@scylladb.com>\n\nCloses scylladb/scylladb#18505","shortMessageHtmlLink":"tools/scylla-nodetool: add formatter for char*"}},{"before":"f604269f0ac7de79e4db31c2cba84cc6d67c02ce","after":"8de81f8f913bfa1809b45a295a6cc347a1083d7d","ref":"refs/heads/next","pushedAt":"2024-05-02T20:24:57.000Z","pushType":"push","commitsCount":21,"pusher":{"login":"avikivity","name":"Avi Kivity","path":"/avikivity","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1017210?s=80&v=4"},"commit":{"message":"Merge 'Unstall merge topology snapshot' from Benny Halevy\n\nThis series adds facilities to gently convert canonical mutations back to mutations\nand to gently make canonical mutations or freeze mutations in a seastar thread.\n\nThose are used in storage_service::merge_topology_snapshot to prevent reactor stalls\ndue to large mutation, as seed in the test_add_many_nodes_under_load dtest.\n\nAlso, migration_manager migration_request was converted to use a seastar thread\nto use the above facilities to prevent reactor stalls with large schema mutations,\ne,g, with a large number of tables, and/or when reading tablets mutations with\na large number of tablets in a table.\n\nperf-simple-query --write results:\nBefore:\n```\nmedian 79151.53 tps ( 59.3 allocs/op,  16.0 logallocs/op,  14.3 tasks/op,   53289 insns/op,        0 errors)\n```\nAfter:\n```\nmedian 79716.73 tps ( 59.3 allocs/op,  16.0 logallocs/op,  14.3 tasks/op,   53314 insns/op,        0 errors)\n```\n\nCloses scylladb/scylladb#18290\n\n* github.com:scylladb/scylladb:\n  storage_proxy: add mutate_locally(vector<frozen_mutation_and_schema>) method\n  raft: group0_state_machine: write_mutations_to_database: freeze mutations gently\n  database: apply_in_memory: unfreeze_gently large mutations\n  storage_service: get_system_mutations: make_canonical_mutation_gently\n  tablets: read_tablet_mutations: make_canonical_mutation_gently\n  schema_tables: convert_schema_to_mutations: make_canonical_mutation_gently\n  schema_tables: redact_columns_for_missing_features: get input mutation using rvalue reference\n  storage_service: merge_topology_snapshot: freeze_gently\n  canonical_mutation: add make_canonical_mutation_gently\n  frozen_mutation: move unfreeze_gently to async_utils\n  mutation: add freeze_gently\n  idl-compiler: generate async serialization functions for stub members\n  raft: group0_state_machine: write_mutations_to_database: use to_mutation_gently\n  storage_service: merge_topology_snapshot: co_await to_mutation_gently\n  canonical_mutation: add to_mutation_gently\n  idl-compiler: emit include directive in generated impl header file\n  mutation_partition: add apply_gently\n  collection_mutation: improve collection_mutation_view formatting\n  mutation_partition: apply_monotonically: do not support schema upgrade\n  test/perf: report also log_allocations/op","shortMessageHtmlLink":"Merge 'Unstall merge topology snapshot' from Benny Halevy"}},{"before":"2cf7cc1ea558e72c6a173c8ceffafcf93b426f4f","after":"e0d597348b64aefe4101a31437a33a7e0351aaf8","ref":"refs/heads/master","pushedAt":"2024-05-02T20:22:13.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"scylladb-promoter","name":null,"path":"/scylladb-promoter","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/36883350?s=80&v=4"},"commit":{"message":"Merge 'Remove sstable_directory::_sstable_dir member' from Pavel Emelyanov\n\nDifferent sstable storage backends use slightly different notion of what sstable location is. Filesystem storage knows it's `/var/lib/data/ks/cf-uuid/state` path, while s3 storage keeps only this path's part without state (and even that's not very accurate, because bucket prefix is missing as well as \"/var/lib/data\" prefix is not needed and eventually should be omitted). Nonetheless, the sstable_directory still keeps the filsystem-like path, while it's really only needed by the filesystem lister. This PR removes it.\n\nCloses scylladb/scylladb#18496\n\n* github.com:scylladb/scylladb:\n  sstable_directory: Remove _sstable_dir member\n  sstable_directory: Create sstable path with make_path() when logging\n  sstable_directory: Use make_path to construct filesystem lister\n  sstable_directory: Move some logging around","shortMessageHtmlLink":"Merge 'Remove sstable_directory::_sstable_dir member' from Pavel Emel…"}},{"before":"e0d597348b64aefe4101a31437a33a7e0351aaf8","after":"f604269f0ac7de79e4db31c2cba84cc6d67c02ce","ref":"refs/heads/next","pushedAt":"2024-05-02T17:54:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"piodul","name":"Piotr Dulikowski","path":"/piodul","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4950936?s=80&v=4"},"commit":{"message":"cql3, secondary index: consistently choose index to use in a query\n\nWhen a table has secondary indexes on *multiple* columns, and several\nsuch columns are used for filtering in a query, Scylla chooses one\nof these indexes as the main driver of the query, and the second\ncolumn's restriction is implemented as filtering.\n\nBefore this patch, the index to use was chosen fairly randomly, based on\nthe order of the indexes in the schema. This order may be different in\ndifferent coordinators, and may even change across restarts on the same\ncoordinators. This is not only inconsistent, it can cause outright wrong\nresults when using *paging* and switching (or restarting) coordinates\nin the middle of a paged scan... One coordinator saves one index's key\nin the paging state, and then the other coordinator gets this paging\nstate and wrongly believes it is supposed to be a key of a *different*\nindex.\n\nThe fix in this patch is to pick the index suitable for the first\nindexed column mentioned in the query. This has two benefits over\nthe situation before the patch:\n\n1. The decision of which index to use no longer changes between\n   coordinators or across restarts - it just depends on the schema\n   and the specific query.\n\n2. Different indexes can have different \"specificity\" so using one\n   or the other can change the query's performance. After this patch,\n   the user is in control over which index is used by changing the\n   order of terms in the query. A curious user can use tracing to\n   check which index was used to implement a particular query.\n\nAn xfailing test we had for this issue no longer fails, so the \"xfail\"\nmarker is removed.\n\nFixes #7969\n\nSigned-off-by: Nadav Har'El <nyh@scylladb.com>\n\nCloses scylladb/scylladb#14450","shortMessageHtmlLink":"cql3, secondary index: consistently choose index to use in a query"}},{"before":"2cf7cc1ea558e72c6a173c8ceffafcf93b426f4f","after":"e0d597348b64aefe4101a31437a33a7e0351aaf8","ref":"refs/heads/next","pushedAt":"2024-05-02T14:52:34.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"avikivity","name":"Avi Kivity","path":"/avikivity","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1017210?s=80&v=4"},"commit":{"message":"Merge 'Remove sstable_directory::_sstable_dir member' from Pavel Emelyanov\n\nDifferent sstable storage backends use slightly different notion of what sstable location is. Filesystem storage knows it's `/var/lib/data/ks/cf-uuid/state` path, while s3 storage keeps only this path's part without state (and even that's not very accurate, because bucket prefix is missing as well as \"/var/lib/data\" prefix is not needed and eventually should be omitted). Nonetheless, the sstable_directory still keeps the filsystem-like path, while it's really only needed by the filesystem lister. This PR removes it.\n\nCloses scylladb/scylladb#18496\n\n* github.com:scylladb/scylladb:\n  sstable_directory: Remove _sstable_dir member\n  sstable_directory: Create sstable path with make_path() when logging\n  sstable_directory: Use make_path to construct filesystem lister\n  sstable_directory: Move some logging around","shortMessageHtmlLink":"Merge 'Remove sstable_directory::_sstable_dir member' from Pavel Emel…"}},{"before":"b8634fb244ab08c2ffa66700745b06e21ee57f30","after":"2cf7cc1ea558e72c6a173c8ceffafcf93b426f4f","ref":"refs/heads/master","pushedAt":"2024-05-02T13:41:10.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"scylladb-promoter","name":null,"path":"/scylladb-promoter","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/36883350?s=80&v=4"},"commit":{"message":"scylla_setup: Remove jmx and tools packages from being verified\n\nFollowing\nhttps://github.com/scylladb/scylladb/commit/b8634fb244ab08c2ffa66700745b06e21ee57f30\nmachine image started to fail with the following error:\n```\n10:44:59  ␛[0;32m    googlecompute.gce: scylla-jmx package is not installed.␛[0m\n10:44:59  ␛[1;31m==> googlecompute.gce: Traceback (most recent call last):␛[0m\n10:44:59  ␛[1;31m==> googlecompute.gce:   File \"/home/ubuntu/scylla_install_image\", line 135, in <module>␛[0m\n10:44:59  ␛[1;31m==> googlecompute.gce:     run('/opt/scylladb/scripts/scylla_setup --no-coredump-setup --no-sysconfig-setup --no-raid-setup --no-io-setup --no-ec2-check --no-swap-setup --no-cpuscaling-setup --no-ntp-setup', shell=True, check=True)␛[0m\n10:44:59  ␛[1;31m==> googlecompute.gce:   File \"/usr/lib/python3.10/subprocess.py\", line 526, in run␛[0m\n10:44:59  ␛[1;31m==> googlecompute.gce:     raise CalledProcessError(retcode, process.args,␛[0m\n10:44:59  ␛[1;31m==> googlecompute.gce: subprocess.CalledProcessError: Command '/opt/scylladb/scripts/scylla_setup --no-coredump-setup --no-sysconfig-setup --no-raid-setup --no-io-setup --no-ec2-check --no-swap-setup --no-cpuscaling-setup --no-ntp-setup' returned non-zero exit status 1.␛[0m\n```\n\nIt seems we no longer need to verify that jmx and tools-java packages are installed.\n\nCloses scylladb/scylladb#18494","shortMessageHtmlLink":"scylla_setup: Remove jmx and tools packages from being verified"}},{"before":"f183f5aa80404ed83044152a6309ff4a0f102b53","after":"2cf7cc1ea558e72c6a173c8ceffafcf93b426f4f","ref":"refs/heads/next","pushedAt":"2024-05-02T10:31:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nyh","name":"Nadav Har'El","path":"/nyh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/584227?s=80&v=4"},"commit":{"message":"scylla_setup: Remove jmx and tools packages from being verified\n\nFollowing\nhttps://github.com/scylladb/scylladb/commit/b8634fb244ab08c2ffa66700745b06e21ee57f30\nmachine image started to fail with the following error:\n```\n10:44:59  ␛[0;32m    googlecompute.gce: scylla-jmx package is not installed.␛[0m\n10:44:59  ␛[1;31m==> googlecompute.gce: Traceback (most recent call last):␛[0m\n10:44:59  ␛[1;31m==> googlecompute.gce:   File \"/home/ubuntu/scylla_install_image\", line 135, in <module>␛[0m\n10:44:59  ␛[1;31m==> googlecompute.gce:     run('/opt/scylladb/scripts/scylla_setup --no-coredump-setup --no-sysconfig-setup --no-raid-setup --no-io-setup --no-ec2-check --no-swap-setup --no-cpuscaling-setup --no-ntp-setup', shell=True, check=True)␛[0m\n10:44:59  ␛[1;31m==> googlecompute.gce:   File \"/usr/lib/python3.10/subprocess.py\", line 526, in run␛[0m\n10:44:59  ␛[1;31m==> googlecompute.gce:     raise CalledProcessError(retcode, process.args,␛[0m\n10:44:59  ␛[1;31m==> googlecompute.gce: subprocess.CalledProcessError: Command '/opt/scylladb/scripts/scylla_setup --no-coredump-setup --no-sysconfig-setup --no-raid-setup --no-io-setup --no-ec2-check --no-swap-setup --no-cpuscaling-setup --no-ntp-setup' returned non-zero exit status 1.␛[0m\n```\n\nIt seems we no longer need to verify that jmx and tools-java packages are installed.\n\nCloses scylladb/scylladb#18494","shortMessageHtmlLink":"scylla_setup: Remove jmx and tools packages from being verified"}},{"before":"b8634fb244ab08c2ffa66700745b06e21ee57f30","after":"f183f5aa80404ed83044152a6309ff4a0f102b53","ref":"refs/heads/next","pushedAt":"2024-05-02T04:35:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"xemul","name":"Pavel Emelyanov","path":"/xemul","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4498177?s=80&v=4"},"commit":{"message":"Update seastar submodule\n\n* seastar 2b43417d...b73e5e7d (11):\n  > treewide: inherit from formatter<string_view> not formatter<std::string_view>\n  > CMakeLists.txt: Apply CXX deprecated flags conditionally\n  > tls: add assignment operator for gnutls_datum\n  > tls: s/get0()/get()/\n  > io_queue: do not reference moved variable\n  > TLS: use helper function in get_distinguished_name & get_alt_name_information\n  > TLS: Add support for TLS1.3 session tickets\n  > iotune: ignore shards with id above max_iodepth\n  > core/future: remove a template parameter from set_callback()\n  > util: with_file_input_stream: always close file\n  > core/sleep: Use more raii-sh aproach to maintain sleeper\n\nFixes #5181\n\nCloses scylladb/scylladb#18491","shortMessageHtmlLink":"Update seastar submodule"}},{"before":"af5674211dd437debdb8938b25d99bbe1956a80f","after":"b8634fb244ab08c2ffa66700745b06e21ee57f30","ref":"refs/heads/master","pushedAt":"2024-05-01T23:43:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"scylladb-promoter","name":null,"path":"/scylladb-promoter","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/36883350?s=80&v=4"},"commit":{"message":"dist: stop installing scylla-tools, scylla-jmx by default\n\nSince we added native nodetool, we no longer need to install scylla-tools\nand scylla-jmx, drop them from scylla metapackage and make it optional\npackage.\n\nCloses #18472\n\nCloses scylladb/scylladb#18487","shortMessageHtmlLink":"dist: stop installing scylla-tools, scylla-jmx by default"}},{"before":"08d1362f8006fe236459f40c5b0d34a13c325c34","after":"af5674211dd437debdb8938b25d99bbe1956a80f","ref":"refs/heads/master","pushedAt":"2024-05-01T20:37:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"scylladb-promoter","name":null,"path":"/scylladb-promoter","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/36883350?s=80&v=4"},"commit":{"message":"redis/server.hh: suppress -Wimplicit-fallthrough from protocol_parser.hh\n\nwhen compiling the tree with clang-18 and ragel 6.10, the compiler\nwarns like:\n\n```\n/usr/local/bin/cmake -E __run_co_compile --tidy=\"clang-tidy-18;--checks=-*,bugprone-use-after-move;--extra-arg-before=--driver-mode=g++\" --source=/home/runner/work/scylladb/scylladb/redis/controller.cc -- /usr/bin/clang++-18 -DBOOST_NO_CXX98_FUNCTION_BASE -DSCYLLA_BUILD_MODE=release -DSEASTAR_API_LEVEL=7 -DSEASTAR_LOGGER_COMPILE_TIME_FMT -DSEASTAR_LOGGER_TYPE_STDOUT -DSEASTAR_SCHEDULING_GROUPS_COUNT=16 -DSEASTAR_SSTRING -DXXH_PRIVATE_API -I/home/runner/work/scylladb/scylladb -I/home/runner/work/scylladb/scylladb/build/gen -I/home/runner/work/scylladb/scylladb/seastar/include -I/home/runner/work/scylladb/scylladb/build/seastar/gen/include -I/home/runner/work/scylladb/scylladb/build/seastar/gen/src -isystem /home/runner/work/scylladb/scylladb/cooking/include -ffunction-sections -fdata-sections -O3 -g -gz -std=gnu++20 -fvisibility=hidden -Wall -Werror -Wextra -Wno-error=deprecated-declarations -Wimplicit-fallthrough -Wno-c++11-narrowing -Wno-deprecated-copy -Wno-mismatched-tags -Wno-missing-field-initializers -Wno-overloaded-virtual -Wno-unsupported-friend -Wno-enum-constexpr-conversion -Wno-unused-parameter -ffile-prefix-map=/home/runner/work/scylladb/scylladb=. -march=westmere -mllvm -inline-threshold=2500 -fno-slp-vectorize -U_FORTIFY_SOURCE -Werror=unused-result -MD -MT redis/CMakeFiles/redis.dir/controller.cc.o -MF redis/CMakeFiles/redis.dir/controller.cc.o.d -o redis/CMakeFiles/redis.dir/controller.cc.o -c /home/runner/work/scylladb/scylladb/redis/controller.cc\nerror: too many errors emitted, stopping now [clang-diagnostic-error]\nError: /home/runner/work/scylladb/scylladb/build/gen/redis/protocol_parser.hh:110:1: error: unannotated fall-through between switch labels [clang-diagnostic-implicit-fallthrough]\n  110 | case 1:\n      | ^\n/home/runner/work/scylladb/scylladb/build/gen/redis/protocol_parser.hh:110:1: note: insert 'FMT_FALLTHROUGH;' to silence this warning\n  110 | case 1:\n      | ^\n      | FMT_FALLTHROUGH;\n```\n\nsince we have `-Werror`, the warnings like this are considered as error,\nhence the build fails. in order to address this failure, let's silence\nthis warning when including this generated header file.\n\nSigned-off-by: Kefu Chai <kefu.chai@scylladb.com>\n\nCloses scylladb/scylladb#18447","shortMessageHtmlLink":"redis/server.hh: suppress -Wimplicit-fallthrough from protocol_parser.hh"}},{"before":"af5674211dd437debdb8938b25d99bbe1956a80f","after":"b8634fb244ab08c2ffa66700745b06e21ee57f30","ref":"refs/heads/next","pushedAt":"2024-05-01T19:15:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"avikivity","name":"Avi Kivity","path":"/avikivity","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1017210?s=80&v=4"},"commit":{"message":"dist: stop installing scylla-tools, scylla-jmx by default\n\nSince we added native nodetool, we no longer need to install scylla-tools\nand scylla-jmx, drop them from scylla metapackage and make it optional\npackage.\n\nCloses #18472\n\nCloses scylladb/scylladb#18487","shortMessageHtmlLink":"dist: stop installing scylla-tools, scylla-jmx by default"}},{"before":"5d992a4f01f0625bd67a1f27f702a5da8b371cad","after":"08d1362f8006fe236459f40c5b0d34a13c325c34","ref":"refs/heads/master","pushedAt":"2024-05-01T17:36:38.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"scylladb-promoter","name":null,"path":"/scylladb-promoter","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/36883350?s=80&v=4"},"commit":{"message":"utils/chunked_vector: fix some typos in comment\n\nSigned-off-by: Kefu Chai <kefu.chai@scylladb.com>\n\nCloses scylladb/scylladb#18486","shortMessageHtmlLink":"utils/chunked_vector: fix some typos in comment"}},{"before":"08d1362f8006fe236459f40c5b0d34a13c325c34","after":"af5674211dd437debdb8938b25d99bbe1956a80f","ref":"refs/heads/next","pushedAt":"2024-05-01T15:47:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"avikivity","name":"Avi Kivity","path":"/avikivity","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1017210?s=80&v=4"},"commit":{"message":"redis/server.hh: suppress -Wimplicit-fallthrough from protocol_parser.hh\n\nwhen compiling the tree with clang-18 and ragel 6.10, the compiler\nwarns like:\n\n```\n/usr/local/bin/cmake -E __run_co_compile --tidy=\"clang-tidy-18;--checks=-*,bugprone-use-after-move;--extra-arg-before=--driver-mode=g++\" --source=/home/runner/work/scylladb/scylladb/redis/controller.cc -- /usr/bin/clang++-18 -DBOOST_NO_CXX98_FUNCTION_BASE -DSCYLLA_BUILD_MODE=release -DSEASTAR_API_LEVEL=7 -DSEASTAR_LOGGER_COMPILE_TIME_FMT -DSEASTAR_LOGGER_TYPE_STDOUT -DSEASTAR_SCHEDULING_GROUPS_COUNT=16 -DSEASTAR_SSTRING -DXXH_PRIVATE_API -I/home/runner/work/scylladb/scylladb -I/home/runner/work/scylladb/scylladb/build/gen -I/home/runner/work/scylladb/scylladb/seastar/include -I/home/runner/work/scylladb/scylladb/build/seastar/gen/include -I/home/runner/work/scylladb/scylladb/build/seastar/gen/src -isystem /home/runner/work/scylladb/scylladb/cooking/include -ffunction-sections -fdata-sections -O3 -g -gz -std=gnu++20 -fvisibility=hidden -Wall -Werror -Wextra -Wno-error=deprecated-declarations -Wimplicit-fallthrough -Wno-c++11-narrowing -Wno-deprecated-copy -Wno-mismatched-tags -Wno-missing-field-initializers -Wno-overloaded-virtual -Wno-unsupported-friend -Wno-enum-constexpr-conversion -Wno-unused-parameter -ffile-prefix-map=/home/runner/work/scylladb/scylladb=. -march=westmere -mllvm -inline-threshold=2500 -fno-slp-vectorize -U_FORTIFY_SOURCE -Werror=unused-result -MD -MT redis/CMakeFiles/redis.dir/controller.cc.o -MF redis/CMakeFiles/redis.dir/controller.cc.o.d -o redis/CMakeFiles/redis.dir/controller.cc.o -c /home/runner/work/scylladb/scylladb/redis/controller.cc\nerror: too many errors emitted, stopping now [clang-diagnostic-error]\nError: /home/runner/work/scylladb/scylladb/build/gen/redis/protocol_parser.hh:110:1: error: unannotated fall-through between switch labels [clang-diagnostic-implicit-fallthrough]\n  110 | case 1:\n      | ^\n/home/runner/work/scylladb/scylladb/build/gen/redis/protocol_parser.hh:110:1: note: insert 'FMT_FALLTHROUGH;' to silence this warning\n  110 | case 1:\n      | ^\n      | FMT_FALLTHROUGH;\n```\n\nsince we have `-Werror`, the warnings like this are considered as error,\nhence the build fails. in order to address this failure, let's silence\nthis warning when including this generated header file.\n\nSigned-off-by: Kefu Chai <kefu.chai@scylladb.com>\n\nCloses scylladb/scylladb#18447","shortMessageHtmlLink":"redis/server.hh: suppress -Wimplicit-fallthrough from protocol_parser.hh"}},{"before":"4e78e2d506d8a078c1127f5fd9d9dbfd3c0e0ab5","after":"08d1362f8006fe236459f40c5b0d34a13c325c34","ref":"refs/heads/next","pushedAt":"2024-05-01T13:38:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"denesb","name":"Botond Dénes","path":"/denesb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1389273?s=80&v=4"},"commit":{"message":"utils/chunked_vector: fix some typos in comment\n\nSigned-off-by: Kefu Chai <kefu.chai@scylladb.com>\n\nCloses scylladb/scylladb#18486","shortMessageHtmlLink":"utils/chunked_vector: fix some typos in comment"}},{"before":"5d992a4f01f0625bd67a1f27f702a5da8b371cad","after":"4e78e2d506d8a078c1127f5fd9d9dbfd3c0e0ab5","ref":"refs/heads/next","pushedAt":"2024-05-01T11:46:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"denesb","name":"Botond Dénes","path":"/denesb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1389273?s=80&v=4"},"commit":{"message":"test/cql-pytest, cdc: add test for what happens when log name is taken\n\nIn our CDC implementation, the CDC log table for table \"xyz\" is always\ncalled \"xyz_scylla_cdc_log\". If this table name is taken, and the user\ntries to create a table \"xyz\" with CDC enabled - or enable CDC on the\ntable \"xyz\", the creation/enabling should fail gracefully, with a clear\nerror message. This test verifies this.\n\nThe new test passes - the code is already correct. I just wanted to\nverify that it is (and to prevent future regressions).\n\nSigned-off-by: Nadav Har'El <nyh@scylladb.com>\n\nCloses scylladb/scylladb#18485","shortMessageHtmlLink":"test/cql-pytest, cdc: add test for what happens when log name is taken"}},{"before":"bd0d246b57bdf8b1dc6c9c117708415bc60a1ce9","after":"5d992a4f01f0625bd67a1f27f702a5da8b371cad","ref":"refs/heads/master","pushedAt":"2024-05-01T11:39:39.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"scylladb-promoter","name":null,"path":"/scylladb-promoter","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/36883350?s=80&v=4"},"commit":{"message":"proxy: Remove declaration of nonexisting view_update_write_response_handler class\n\nSigned-off-by: Pavel Emelyanov <xemul@scylladb.com>\n\nCloses scylladb/scylladb#18417","shortMessageHtmlLink":"proxy: Remove declaration of nonexisting view_update_write_response_h…"}},{"before":"f71a687baf1f282fbca134ae7d082f3fd915cc32","after":"5f5acc813a331ca0556b608eaae035524a8a4a43","ref":"refs/heads/branch-5.2","pushedAt":"2024-05-01T11:02:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"scylladb-promoter","name":null,"path":"/scylladb-promoter","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/36883350?s=80&v=4"},"commit":{"message":"view-builder: Print correct exception in built ste exception handler\n\nInside .handle_exception() continuation std::current_exception() doesn't\nwork, there's std::exception ex argument to handler's lambda instead\n\nfixes #18423\n\nSigned-off-by: Pavel Emelyanov <xemul@scylladb.com>\n\nCloses scylladb/scylladb#18349\n\n(cherry picked from commit 4ac30e5337c7be529fa28259eeabd8748646da1c)","shortMessageHtmlLink":"view-builder: Print correct exception in built ste exception handler"}},{"before":"d85d37921aabe640679ad5b16e4616b7898e2c0a","after":"d68d765247159ce61a605ae7c6a2e274204e8361","ref":"refs/heads/branch-5.4","pushedAt":"2024-05-01T09:41:08.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"scylladb-promoter","name":null,"path":"/scylladb-promoter","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/36883350?s=80&v=4"},"commit":{"message":"view-builder: Print correct exception in built ste exception handler\n\nInside .handle_exception() continuation std::current_exception() doesn't\nwork, there's std::exception ex argument to handler's lambda instead\n\nfixes #18423\n\nSigned-off-by: Pavel Emelyanov <xemul@scylladb.com>\n\nCloses scylladb/scylladb#18349\n\n(cherry picked from commit 4ac30e5337c7be529fa28259eeabd8748646da1c)","shortMessageHtmlLink":"view-builder: Print correct exception in built ste exception handler"}},{"before":"b980634ff2b63edb6f7cac87cf93f193b23cf2c9","after":"bd0d246b57bdf8b1dc6c9c117708415bc60a1ce9","ref":"refs/heads/master","pushedAt":"2024-05-01T08:34:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"scylladb-promoter","name":null,"path":"/scylladb-promoter","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/36883350?s=80&v=4"},"commit":{"message":"tools/scylla-nodetool: implement the resetlocalschema command\n\nFixes #18468\nSigned-off-by: Kefu Chai <kefu.chai@scylladb.com>\n\nCloses scylladb/scylladb#18470","shortMessageHtmlLink":"tools/scylla-nodetool: implement the resetlocalschema command"}},{"before":"72746286638aa475449f771288d656bfb0199d17","after":null,"ref":"refs/heads/mergify/copy/branch-5.2/pr-18349","pushedAt":"2024-05-01T07:21:29.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"}},{"before":"f71a687baf1f282fbca134ae7d082f3fd915cc32","after":"5f5acc813a331ca0556b608eaae035524a8a4a43","ref":"refs/heads/next-5.2","pushedAt":"2024-05-01T07:20:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"denesb","name":"Botond Dénes","path":"/denesb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1389273?s=80&v=4"},"commit":{"message":"view-builder: Print correct exception in built ste exception handler\n\nInside .handle_exception() continuation std::current_exception() doesn't\nwork, there's std::exception ex argument to handler's lambda instead\n\nfixes #18423\n\nSigned-off-by: Pavel Emelyanov <xemul@scylladb.com>\n\nCloses scylladb/scylladb#18349\n\n(cherry picked from commit 4ac30e5337c7be529fa28259eeabd8748646da1c)","shortMessageHtmlLink":"view-builder: Print correct exception in built ste exception handler"}},{"before":"fc07956698f09874296a87dee060c88380798283","after":null,"ref":"refs/heads/mergify/copy/branch-5.4/pr-18349","pushedAt":"2024-05-01T07:20:28.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"}},{"before":"d8df02f4905c917d530acf85644b70c334c1fe54","after":"d68d765247159ce61a605ae7c6a2e274204e8361","ref":"refs/heads/next-5.4","pushedAt":"2024-05-01T07:19:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"denesb","name":"Botond Dénes","path":"/denesb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1389273?s=80&v=4"},"commit":{"message":"view-builder: Print correct exception in built ste exception handler\n\nInside .handle_exception() continuation std::current_exception() doesn't\nwork, there's std::exception ex argument to handler's lambda instead\n\nfixes #18423\n\nSigned-off-by: Pavel Emelyanov <xemul@scylladb.com>\n\nCloses scylladb/scylladb#18349\n\n(cherry picked from commit 4ac30e5337c7be529fa28259eeabd8748646da1c)","shortMessageHtmlLink":"view-builder: Print correct exception in built ste exception handler"}},{"before":"66ca138a72b17e6e00952646820b091601b483c5","after":null,"ref":"refs/heads/mergify/copy/branch-5.4/pr-18424","pushedAt":"2024-05-01T07:18:01.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"}},{"before":"d85d37921aabe640679ad5b16e4616b7898e2c0a","after":"d8df02f4905c917d530acf85644b70c334c1fe54","ref":"refs/heads/next-5.4","pushedAt":"2024-05-01T07:17:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"denesb","name":"Botond Dénes","path":"/denesb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1389273?s=80&v=4"},"commit":{"message":"docs: clarify that `DELETE` can be used with `USING TIMEOUT`\n\nThe current text seems to suggest that `USING TIMEOUT` doesn't work with `DELETE` and `BATCH`. But that's wrong.\n\nCloses scylladb/scylladb#18424\n\n(cherry picked from commit c1146314a18e6480c5b7f11338d255100ceba902)","shortMessageHtmlLink":"docs: clarify that <code>DELETE</code> can be used with <code>USING TIMEOUT</code>"}},{"before":"65a385f5d0274fa830c298e14cc02ed6950d8ebe","after":"5d992a4f01f0625bd67a1f27f702a5da8b371cad","ref":"refs/heads/next","pushedAt":"2024-05-01T07:15:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"denesb","name":"Botond Dénes","path":"/denesb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1389273?s=80&v=4"},"commit":{"message":"proxy: Remove declaration of nonexisting view_update_write_response_handler class\n\nSigned-off-by: Pavel Emelyanov <xemul@scylladb.com>\n\nCloses scylladb/scylladb#18417","shortMessageHtmlLink":"proxy: Remove declaration of nonexisting view_update_write_response_h…"}},{"before":"94ac0799d998cf20632b9113e0d6d9a8b29050b4","after":"65a385f5d0274fa830c298e14cc02ed6950d8ebe","ref":"refs/heads/next","pushedAt":"2024-05-01T07:15:05.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"denesb","name":"Botond Dénes","path":"/denesb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1389273?s=80&v=4"},"commit":{"message":"Merge 'Relax the way view builder code checks if a table exists' from Pavel Emelyanov\n\nThere are two places that workaround db.column_family_exists() call with some fancy exceptions-catching lambda.\nThis PR makes things simpler.\n\nCloses scylladb/scylladb#18441\n\n* github.com:scylladb/scylladb:\n  view: Open-code one line lambda checking if table exists\n  view: Use non-throwoing check if a table exists","shortMessageHtmlLink":"Merge 'Relax the way view builder code checks if a table exists' from…"}},{"before":"f0d12df7fc6f50b6cf6612d8180e431a0abd364b","after":"94ac0799d998cf20632b9113e0d6d9a8b29050b4","ref":"refs/heads/next","pushedAt":"2024-05-01T07:08:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"denesb","name":"Botond Dénes","path":"/denesb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1389273?s=80&v=4"},"commit":{"message":"build: cmake: link scylla_tracing against scylla-main\n\nbecause tracing/trace_keyspace_helper.cc references symbols\ndefined by table_helper, which is in turn provided by scylla-main,\nwe should link tracing_tracing against scylla-main.\n\notherwise we could have following link failure:\n\n```\n./build/./tracing/trace_keyspace_helper.cc:214: error: undefined reference to 'table_helper::setup_keyspace(cql3::query_processor&, service::migration_manager&, std::basic_string_view<char, std::char_traits<char> >, seastar::basic_sstring<char, unsigned int, 15u, true>, service::query_state&, std::vector<table_helper*, std::allocator<table_helper*> >)'\n./build/./tracing/trace_keyspace_helper.cc:396: error: undefined reference to 'table_helper::cache_table_info(cql3::query_processor&, service::migration_manager&, service::query_state&)'\n./table_helper.hh:92: error: undefined reference to 'table_helper::insert(cql3::query_processor&, service::migration_manager&, service::query_state&, seastar::noncopyable_function<cql3::query_options ()>)'\n./table_helper.hh:92: error: undefined reference to 'table_helper::insert(cql3::query_processor&, service::migration_manager&, service::query_state&, seastar::noncopyable_function<cql3::query_options ()>)'\n./table_helper.hh:92: error: undefined reference to 'table_helper::insert(cql3::query_processor&, service::migration_manager&, service::query_state&, seastar::noncopyable_function<cql3::query_options ()>)'\n./table_helper.hh:92: error: undefined reference to 'table_helper::insert(cql3::query_processor&, service::migration_manager&, service::query_state&, seastar::noncopyable_function<cql3::query_options ()>)'\nclang++-18: error: linker command failed with exit code 1 (use -v to see invocation)\nninja: build stopped: subcommand failed.\n```\n\nSigned-off-by: Kefu Chai <kefu.chai@scylladb.com>\n\nCloses scylladb/scylladb#18455","shortMessageHtmlLink":"build: cmake: link scylla_tracing against scylla-main"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEQN2H0wA","startCursor":null,"endCursor":null}},"title":"Activity · scylladb/scylladb"}