Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation - Get is by Primary Key, not Partition Key? #244

Open
steve-gray opened this issue Oct 11, 2022 · 2 comments
Open

Documentation - Get is by Primary Key, not Partition Key? #244

steve-gray opened this issue Oct 11, 2022 · 2 comments
Assignees

Comments

@steve-gray
Copy link

I believe some of the code comments is misleading. The SelectQueryContext operation is by partition key, however GetQueryContext is by the full primary key?

// GetQueryContext returns query wrapped with context which gets by partition key.

image

Observationally it seems to work as a primary key search, not a partitioning key search - so maybe worth clarifying in the documentation?

@gronka
Copy link

gronka commented Apr 25, 2023

Seems like a simple bug to fix/clarify

I use partition keys a lot, so I'd appreciate more clarity here if possible

@alfa-alex
Copy link
Contributor

alfa-alex commented Jul 12, 2023

There's a fix for this in #257.

Update Mar 23, 2024: This fix was just merged into master. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants