Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonarr for anime only - remove requirement #2876

Open
1 task done
Mezhona opened this issue Aug 1, 2022 · 33 comments · May be fixed by #3664
Open
1 task done

Sonarr for anime only - remove requirement #2876

Mezhona opened this issue Aug 1, 2022 · 33 comments · May be fixed by #3664

Comments

@Mezhona
Copy link

Mezhona commented Aug 1, 2022

Description

I use a separate sonarr instance for my anime collection, the main reason it's to big and clutters up my tv catalogue.
So when setting up overseerr, I'm unable to set up my anime sonarr without having to set up a tv category within it for overseer.

Desired Behavior

Not have a requirement for TV-shows, either option should be fine when setting it up, requirement for either tv or anime, but one needs to be set up.

Additional Context

No response

Code of Conduct

  • I agree to follow Overseerr's Code of Conduct
@Quafley
Copy link

Quafley commented Sep 22, 2022

I would like to add something to this request if possible. Like described, series are required to be filled in. Overseerr clearly sees the difference between anime and series. It would be nice if you can assign instance 1 to series and instance 2 to anime and that the chosen media (by the end user) will be automatically send accordingly (series for series instance, anime to anime instance). This way we don't have to resort to giving end-users advanced options which cause all kinds of mess.

@dephcon

This comment was marked as spam.

@Quafley

This comment was marked as spam.

@rekonnected
Copy link

A potential way to implement this would to extend the functionality used to determine Default/4K servers, adding a third optional check box (Anime Server) to the section pictured below (Add Sonarr Server), and using that to determine whether to show/require the standard TV settings or not.

image

@rcdailey
Copy link

rcdailey commented Oct 18, 2022

@rekonnected Wouldn't an anime server be mutually exclusive to 4K? At least, 4K anime isn't really a "thing". The general UX issue I see with checkboxes is that you need to ensure they are compatible with all options, as well as options that might get added later. Something else like a combo/list control would be better suited in a situation where there's mutual exclusivity.

I also struggle to understand why we need a toggle for this anyway. Wouldn't we simply need to remove the "required" validation on the TV/Series fields, and as the OP states, simply validate that at least one or both are present? If I only fill in the anime fields, that's effectively the same as checking the box you are proposing.

Overseerr can then handle other parts of the UI based on which fields were set up (Series, Anime, or both), for example: If only anime is configured, then when users request TV series, that server will not be an available choice. Likewise for Anime. I realize this last part goes out of scope, but just something to think about that might influence the UX for this.

@Quafley
Copy link

Quafley commented Nov 3, 2022

This sounds logical. Would love to see the thoughts on this by the developers. This can significantly improve the usability of overseerr. We're now forced, if you want easy requesting of media for your users and not have them request using advanced options, to use 1 instance of sonarr. This is very impractical for many reasons. Would love to see the thoughts of the developers on this topic, and if it is even possible.

@stale

This comment was marked as resolved.

@stale stale bot added the stale label Jan 3, 2023
@RomLecat

This comment was marked as resolved.

@MattSidney
Copy link

Would also be keen to see this implemented.

As per some other user comments though I think it would make sense to set this up so it is a little 'smarter'
If a server has two instances of sonarr, one for tv and one for anime, then it would be great if the correct instance was automatically selected when a user is requesting an anime vs tv show.

@stale stale bot removed the stale label Jan 4, 2023
@stale

This comment was marked as resolved.

@stale stale bot added the stale label Apr 2, 2023
@flan7
Copy link

flan7 commented Apr 3, 2023

begone stale bot

@aleksasiriski
Copy link

+1 for this functionality

@stale stale bot removed the stale label Apr 10, 2023
@rcdailey
Copy link

Seriously, stale bots are the worst. It forces folks to post "+1" and other unhelpful comments just to fight the bot and prevent issues from getting closed without any human involvement or rationale.

I understand the purpose of the bot. An open source project only has so many contributors and it's impossible to get to every single issue. However, I do not believe a bot improves this situation. It just limits visibility of legitimate issues that might otherwise get worked on based on some type of prioritization methodology.

I encourage the Overseerr developers to consider disabling the bot in favor of prioritization (something as simple as sorting by upvotes is common and certainly more useful than closing issues, in my view).

Thanks again to everyone for the hard work on Overseerr!

@skaza2125
Copy link

Would also love to see this implemented, I think it would be an amazing addition building on exisiting functionality. Right now I run two overseerr instance, one for normal media and one for anime, and since it is recommended to have two different sonar instances(one for normal media one for anime) this would go hand in hand with that, eliminating the need for two instances, greatly simplifying the experience for the end user.

@begna112
Copy link

+1 avoiding polluting my tv and 4k tv sonarr servers with anime would be highly appreciated. Currently my non-technical users/family members have no way to choose which server it gets sent to (by design), so only I can add anime for them.
Screenshot_20230623_223703_Chrome

@Quafley
Copy link

Quafley commented Aug 12, 2023

bump, this is a much needed feature.

@Feramance
Copy link

I've recently been thinking about this and I personally think the best way around this issue is to separate Anime from regular instances. Currently when setting up a sonarr instance you select the profiles for both anime and non-anime shows. Like what was suggested, we need a tick box to mark a sonarr instance as anime or not, and when requesting any anime content it first checks for an anime instance and if there isn't one, it then uses the default instance settings. Naturally in the case of the anime instance, the anime profiles should be used. This was everything remains backwards compatible with previous builds for everyone who wants to use the current functionality.

@Quafley
Copy link

Quafley commented Sep 29, 2023

instance

That is a good idea. It would be nice to also get an answer from the developers, since this has been open for a year.

@OwsleyJr OwsleyJr mentioned this issue Oct 9, 2023
1 task
@dephcon
Copy link

dephcon commented Oct 27, 2023

any updates devs? surely this functionality would help a bunch of people

@pachungulo
Copy link

This issue is the main reason that I only run 1 sonarr even though 2 sonarr would be ideal. Very much needed!!

@thempc
Copy link

thempc commented Oct 30, 2023

I have a version locally which adds this. I'll make a pull request for this soon, not sure if it'll be accepted though.
image

thempc added a commit to thempc/overseerr that referenced this issue Oct 30, 2023
thempc added a commit to thempc/overseerr that referenced this issue Oct 30, 2023
@thempc thempc linked a pull request Oct 30, 2023 that will close this issue
3 tasks
@dephcon
Copy link

dephcon commented Oct 30, 2023

@thempc thank you for doing this (even if it gets rejected)

@rcdailey
Copy link

I have a version locally which adds this. I'll make a pull request for this soon, not sure if it'll be accepted though. image

Not all heroes wear capes

@Quafley
Copy link

Quafley commented Oct 31, 2023

I have a version locally which adds this. I'll make a pull request for this soon, not sure if it'll be accepted though.
image

Hello mate, this is awesome news. How far integrated is this? Will the instance be automatically chosen based on the type of media requested?

@thempc
Copy link

thempc commented Oct 31, 2023

I have a version locally which adds this. I'll make a pull request for this soon, not sure if it'll be accepted though.
image

Hello mate, this is awesome news. How far integrated is this? Will the instance be automatically chosen based on the type of media requested?

Happy you like it, currently it's in the review process so there will feedback at some point to the code changes, to which there will likely be more code changes, so integration-wise we're just beginning to get this merged in (if the dev team wants this).

As for the chosing of instances, that is all automated based on media type yes. If you have two Sonarr or Radarr instances, one with the Anime default, and one without, all Anime type requests automatically go to the Anime instance, while non-anime goes to the other default non-anime instance.

If on the other hand, only one Default server (non-anime) is setup, all anime requests are directed there instead. Making this a non-destructive setup, working for both people who have single and multiple instance setups.

@Quafley
Copy link

Quafley commented Oct 31, 2023

I have a version locally which adds this. I'll make a pull request for this soon, not sure if it'll be accepted though.
image

Hello mate, this is awesome news. How far integrated is this? Will the instance be automatically chosen based on the type of media requested?

Happy you like it, currently it's in the review process so there will feedback at some point to the code changes, to which there will likely be more code changes, so integration-wise we're just beginning to get this merged in (if the dev team wants this).

As for the chosing of instances, that is all automated based on media type yes. If you have two Sonarr or Radarr instances, one with the Anime default, and one without, all Anime type requests automatically go to the Anime instance, while non-anime goes to the other default non-anime instance.

If on the other hand, only one Default server (non-anime) is setup, all anime requests are directed there instead. Making this a non-destructive setup, working for both people who have single and multiple instance setups.

If you need help testing stuff out, feel free to reach out. Would be more than happy to run your fork for now and test stuff with you.

@thempc
Copy link

thempc commented Oct 31, 2023

Well, I've been testing and fleshing things out since making the pull request. I think it's in a pretty solid place atm. If anyone wants to test/use it while its under review, you can grab this branch:

https://github.com/thempc/overseerr/tree/feature-default-anime-instance-checkbox

You'll need to follow the standard Overseerr compilation instructions.

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 17, 2024
@thempc
Copy link

thempc commented Mar 17, 2024

Just bumping to prevent going stale.

Edit: Removed a previous comment, it wasn't very contributing.

@stale stale bot removed the stale label Mar 17, 2024
@speatzle
Copy link

speatzle commented Mar 17, 2024

I have been following this and oidc support for a long time, at this point it might make sense to send the PRs to jellyseerr instead. Counter to the name it still supports plex, but i personally run jellyfin now anyway.

@thempc
Copy link

thempc commented Mar 17, 2024

@speatzle I asked about it in their #development channel, in case you wish to follow.

Edit: Jellyseerr team said to just wait for Overseerr integration, so I guess we stuck again.

@Infray
Copy link

Infray commented Mar 22, 2024

@thempc Thanks for the work you've put into this.
From what I can see everything works pretty well using the web interface.

However I was trying to use requestrr to request a show via overseerr and I got following warning in the logs:
There is no default Sonarr server configured. Did you set any of your Sonarr servers as default?

Are the changes in your PR only on the webui or are these also applicable to the api and is this a requestrr issue?

@thempc
Copy link

thempc commented Mar 23, 2024

@Infray I continued here: #3664 (comment) to keep talk my code implementation separate from the topic as a whole.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.