Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sometimes get NaNs from GSIC #27

Open
bvegawe opened this issue Apr 5, 2018 · 1 comment
Open

sometimes get NaNs from GSIC #27

bvegawe opened this issue Apr 5, 2018 · 1 comment

Comments

@bvegawe
Copy link
Collaborator

bvegawe commented Apr 5, 2018

GSIC produces NaNs if it all melts.
bvegawe added a commit to bvegawe/BRICK that referenced this issue Apr 5, 2018
@bvegawe
Set maximum contribution from gsic to V0
796b27c 
This addresses issue scrim-network#27, where GSIC produces NaNs when it tries to calculate after full melt
@bvegawe bvegawe mentioned this issue Apr 5, 2018
Open
@bvegawe
Copy link
Collaborator Author

bvegawe commented Apr 5, 2018

Perhaps this isn't really an issue? In my calibrations of the Hector model, sometimes I get NaNs when technically it should be V0, but bugging out is probably not a horrible response either (I presume full melt is fairly unrealistic under normal circumstances).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bvegawe