Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not recognise Dominant chord #93

Open
etamity opened this issue Dec 3, 2019 · 2 comments
Open

Not recognise Dominant chord #93

etamity opened this issue Dec 3, 2019 · 2 comments

Comments

@etamity
Copy link

etamity commented Dec 3, 2019

I think the isNote function need to update , as it can't recognise C7, Edim chords.

I would suggest any note start with lower case letter to recognise as Note
and take full chord mapping from tonal library.

@walmik
Copy link
Collaborator

walmik commented Dec 8, 2019

Hi @etamity We have a similar issue for C5, C13 etc. In Scribbletune we map these chords with the th suffix. Please note the comments here https://github.com/scribbletune/scribbletune/blob/master/src/chord.ts#L31-L32

One other thing to note is, Scribbletune even returns these chord names with the th suffix in the chords method https://github.com/scribbletune/scribbletune/blob/master/src/chord.ts#L61-L62

For Edim, that s a great observation! The diminished chord is denoted by o from tonal and Scribbletune carries the same convention forward. To use Edim please try Eo - that s the lower case letter o - not zero ;)

@etamity
Copy link
Author

etamity commented Dec 9, 2019

Hi @walmik ,
Thank you, that helps!
Somehow I still feel like C5, C7 , Cdim are standard chord name in the music industry , it will be great to align with the standards.
If we can take all lower case letter as note, the problem will be resolved. like:

c1,c2,c3 ...

Just a suggestion, and well done for this great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants