Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why attrib() is the only one method that doesn't contain any checks? #284

Open
beskrovniibv opened this issue Oct 6, 2023 · 1 comment
Open

Why attrib() is the only one method that doesn't contain any checks? #284

beskrovniibv opened this issue Oct 6, 2023 · 1 comment

Comments

@beskrovniibv
Copy link

parsel/parsel/selector.py

Line 856 in 0475327

def attrib(self) -> Dict[str, str]:

While the other methods raised clear exceptions attrib() confused developers with built-in AttributeError when self.root has no attribute attrib.
@wRAR
Copy link
Member

wRAR commented Oct 15, 2023

When does that happen? Is it only a problem for JSON selectors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wRAR @beskrovniibv