Allow passing over kwargs in .extract() #102

Granitosaurus · 2017-09-30T15:28:58Z

Since extract() method is just a wrapper around lxml.etree.tostring it would make sense allowing of kwargs passthrough. This would enable more flexibility for getting string data.

For example it allows usage of pretty_print kwarg:

>>> foo = '<body><div>hi</div></body>'
>>> from parsel import Selector
>>> Selector(text=foo).extract()
'<html><body><div>hi</div></body></html>'
# vs
>>> print(Selector(text=foo).extract(pretty_print=True, method='xml'))
<html>
  <body>
    <div>hi</div>
  </body>
</html>

See my attempt at patch for this: #101

The text was updated successfully, but these errors were encountered:

Gallaecio added the enhancement label Aug 22, 2019

Gallaecio added the discuss label Sep 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow passing over kwargs in .extract() #102

Allow passing over kwargs in .extract() #102

Granitosaurus commented Sep 30, 2017 •

edited

Allow passing over kwargs in .extract() #102

Allow passing over kwargs in .extract() #102

Comments

Granitosaurus commented Sep 30, 2017 • edited

Granitosaurus commented Sep 30, 2017 •

edited