Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*_{css,xpath} taking multiple selectors #63

Open
wRAR opened this issue Feb 26, 2023 · 1 comment
Open

*_{css,xpath} taking multiple selectors #63

wRAR opened this issue Feb 26, 2023 · 1 comment

Comments

@wRAR
Copy link
Member

wRAR commented Feb 26, 2023

When adding typing I've discovered some strange (to me) code which is covered by tests and is present since CSS/XPath were added in 2013. Quoting tests:

l.replace_css('name', ['p::text', 'div::text'])
l.get_css(['p::text', 'div::text'])

Yet it was always documented that these functions take a "selector" in a form of "str".

Looks like we need to at least document this, as we will need to type these as Union[str, Iterable[str]]. We could remove it instead but I have no idea if it's used (I also have no idea about the actual use cases for this).

@wRAR wRAR added the question Further information is requested label Feb 26, 2023
@Gallaecio
Copy link
Member

We could deprecate it, and if no one complains and suggest a valid use case, eventually remove it.

@wRAR wRAR removed the question Further information is requested label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants