Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding folders to UI #224

Open
ulasozguler opened this issue Mar 7, 2023 · 6 comments
Open

Adding folders to UI #224

ulasozguler opened this issue Mar 7, 2023 · 6 comments

Comments

@ulasozguler
Copy link

Hi, great tool!

This is a feature request that I might be interested in implementing if you approve.

I know S3 is basically a key-value store but a lot of people are using slashes as folders. If you have lots of nested folders, it's really hard to navigate the current UI.

It looks like this:
Screenshot 2023-03-07 at 15 27 33

I'm suggesting adding folders to UI so you can browse a specific key prefix like a/b/c.

It's already possible to list a specific prefix by using search but results still display the prefix, which doesn't help a lot.
You also need to url encode the search term if you have slashes (or other special characters) in the prefix, which I assume is a bug.

Let me know your thoughts.

@jakobvogel
Copy link
Member

Hello @ulasozguler 👋 Many thanks for your input!

We ourselves use S3 really as a simple key-value store, and the existing UI is sufficient for our purposes. However, we agree that others use a pseudo-folder structure and would benefit from the suggested change. So, if you really want to implement this, we would appreciate your efforts.

If you begin the work, please push early and create a draft PR for this. Also, please implement the folder view such that it is optional, besides the current view. We do not want to entirely replace the current view.

Please also note that we recently revised the UI. I just released the respective version today.

You are right, the prefix search seems to be buggy if it requires manual URL encoding. Could you please file a new issue for this? I would like to process this separately. Thanks! 😊

@ulasozguler
Copy link
Author

Thanks for the reply. I'm not big on Java but I'll give it a go this weekend.
I've created the issue related to search: #225

@jakobvogel
Copy link
Member

Thanks @ulasozguler – Unfortunately, I will be away during the upcoming weekend. But feel free to ask questions here (or in a future draft PR) if you run into problems, and I will try to respond asap.

@hradec
Copy link

hradec commented Oct 3, 2023

+1 on the folder display. We also use a lot of folder structured data with lots of files inside folders, and it's almost impossible to find a new folder if we don't know the name of the folder due to the large amount of files.

@ulasozguler Did you ever got to work on this?

@ulasozguler
Copy link
Author

+1 on the folder display. We also use a lot of folder structured data with lots of files inside folders, and it's almost impossible to find a new folder if we don't know the name of the folder due to the large amount of files.

@ulasozguler Did you ever got to work on this?

I've never got to it. Feel free to take over if you are interested.

@smohanty92
Copy link

Hi, great tool!

This is a feature request that I might be interested in implementing if you approve.

I know S3 is basically a key-value store but a lot of people are using slashes as folders. If you have lots of nested folders, it's really hard to navigate the current UI.

It looks like this: Screenshot 2023-03-07 at 15 27 33

I'm suggesting adding folders to UI so you can browse a specific key prefix like a/b/c.

It's already possible to list a specific prefix by using search but results still display the prefix, which doesn't help a lot. You also need to url encode the search term if you have slashes (or other special characters) in the prefix, which I assume is a bug.

Let me know your thoughts.

How did you even upload a folder to s3-ninja like that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants