Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Kubernetes #211

Open
riccardomessineo opened this issue Nov 7, 2022 · 0 comments
Open

Compatibility with Kubernetes #211

riccardomessineo opened this issue Nov 7, 2022 · 0 comments

Comments

@riccardomessineo
Copy link

riccardomessineo commented Nov 7, 2022

Hello there,
I am trying to replicate a perfectly running docker-compose config on a k8s cluster using the virtual hosted style feature.
Listing the buckets works fine, but accessing the files of a bucket returns an empty set.
I'm pretty sure it's a problem related to virtual hosted style buckets on k8s, and I have a hint on where the problem is:
https://github.com/scireum/s3ninja/blob/master/src/main/java/ninja/S3Dispatcher.java#L287

While figuring out how to make the s3 request you try to understand the local domains with:
https://github.com/scireum/s3ninja/blob/master/src/main/java/ninja/S3Dispatcher.java#L161-L179

To make it work on docker-compose I had to set the hostname property to s3ninja.dev, but on k8s this is not possible!

To fix this can you add a "baseurl" on the config file in the "http" section and use it in the DOMAINS as a value?
If I knew Java I would PR this fix...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant