Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fodf metrics should be a module #64

Closed
karanphil opened this issue Feb 8, 2024 · 1 comment · Fixed by #72
Closed

Fodf metrics should be a module #64

karanphil opened this issue Feb 8, 2024 · 1 comment · Fixed by #72
Labels
enhancement New feature or request

Comments

@karanphil
Copy link
Contributor

I think scil_compute_fodf_metrics.py should be in a module in itself, and not inside the fodf module. The reason is, it would be nice to have a ssstfodf and a msmtfodf (damn no _!) module. A module fodfmetrics, just like the dtimetrics, would take as input any SH file.

@Manonedde Manonedde linked a pull request Feb 15, 2024 that will close this issue
8 tasks
@AlexVCaron AlexVCaron added this to the nf-scil modules v1.0 milestone Feb 23, 2024
@AlexVCaron
Copy link
Collaborator

AlexVCaron commented Feb 23, 2024

Hi @karanphil ! I had a thought about this, and I think in the end we should sought something akin to what you propose. I really like the idea of having ssstfodf and msmtfodf as separate modules (and eventually memsmt !), it works with the logic of nf-scil, makes the modules interface a bit clearer and trying to bunch both in the same module could create a really ugly script.

However, as discussed, the metric script call will stay inside those modules. Its going to create duplication, but we'll handle this in future iterations. You can however still propose a module doing only metrics computation, for both DTI and SH, I am all good with that !

@AlexVCaron AlexVCaron added the enhancement New feature or request label Feb 23, 2024
@AlexVCaron AlexVCaron removed this from the nf-scil modules v1.0 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants