Consider bumping C standard in meson.build from C99 to C17 #28977
Labels
Bug
free-threading
PRs and issues related to support for free-threaded CPython (a.k.a. nogil or no-GIL, PEP 703)
Describe the bug
Currently, trying to build scikit-learn with the python 3.13 free-threaded build leads to a compilation error related to usage of
static_assert
in CPython internals. This leaks into public code via cython's adding#include "internal/pycore_frame.h"
to module init code.See scipy/scipy#20515 where scipy made a similar change for similar reasons.
C17 is well-supported by downstream compilers, including MSVC. CPython itself is built with C11, which is a superset of C17.
Opening this as an issue instead of just making a pull request to see if there are good reasons besides inertia why
meson.build
specifies C99.Steps/Code to Reproduce
python -m pip install -v . --no-build-isolation
Expected Results
successful build
Actual Results
Versions
Current `main` branch.
The text was updated successfully, but these errors were encountered: