You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When adding global_random_seed to a test, it's not enough to check it locally, i.e. on a single machine. Numerical precision issues can come from various factors like OS, CPU, BLAS, ...
When adding global_random_seed, it's important to test all random seeds on all CI jobs. To do that, you need to push a commit with [all random seeds] and the list of tests to check in the commit message:
some message [all random seeds]
test_something
test_some_other_thing
If this is not done, we merge the PR and then the nightly builds fail every once in a while because the tolerance was barely too small for some seed.
The text was updated successfully, but these errors were encountered:
@jeremiedbb I would like to contribute to this, but am new to CI. To improve this issue, my understanding is to add [all random seeds] in tests in .yml files in each CI. Is that correct?
When adding
global_random_seed
to a test, it's not enough to check it locally, i.e. on a single machine. Numerical precision issues can come from various factors like OS, CPU, BLAS, ...When adding
global_random_seed
, it's important to test all random seeds on all CI jobs. To do that, you need to push a commit with[all random seeds]
and the list of tests to check in the commit message:If this is not done, we merge the PR and then the nightly builds fail every once in a while because the tolerance was barely too small for some seed.
The text was updated successfully, but these errors were encountered: