Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installations contain __init__.py in subdirectories of packages even if they are not explicitly requested #676

Open
vyasr opened this issue Mar 9, 2022 · 2 comments · May be fixed by #797
Open

Installations contain __init__.py in subdirectories of packages even if they are not explicitly requested #676

vyasr opened this issue Mar 9, 2022 · 2 comments · May be fixed by #797
Assignees
@jcfr @aaron-bray

Comments

@vyasr
Copy link
Contributor

vyasr commented Mar 9, 2022

Given a package layout like so

    .
    ├── package
    |   ├── __init__.py
    │   ├── subpackage
    |       ├── __init__.py
    |       ├── subpackage_module.py

if I do not add a cython target or a library for subpackage, subpackage/subpackage_module.py is not copied into the install tree, but subpackage/__init__.py is. I would guess that this is because of some special treatment of __init__.py files.
@jcfr jcfr self-assigned this Mar 10, 2022
@jcfr
Copy link
Contributor

jcfr commented Mar 10, 2022

Related issue described at rapidsai/rmm#976 (comment)

@aaron-bray
Copy link
Contributor

I created a project that reproduces the issue here

https://github.com/aaron-bray/scikit-build/tree/676-cython-subdirectories/tests/samples/issue-676-cython-subdirectories

@jcfr jcfr linked a pull request Nov 22, 2022 that will close this issue
Address Issue #676 #797
Open
@henryiii henryiii linked a pull request Jan 19, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcfr jcfr

@aaron-bray aaron-bray

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address Issue #676 aaron-bray/scikit-build
4 participants
@jcfr @vyasr @aaron-bray and others