Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sufficiently new cmake should be preferred over cmake3 #1066

Open
ngoldbaum opened this issue Feb 13, 2024 · 1 comment
Open

Sufficiently new cmake should be preferred over cmake3 #1066

ngoldbaum opened this issue Feb 13, 2024 · 1 comment

Comments

@ngoldbaum
Copy link

ngoldbaum commented Feb 13, 2024

I'm helping someone debug an issue building some software in a conda environment. The package they're building uses scikit-build and they happen to have a /usr/bin/cmake3 executable in their PATH. See here.

Because of these lines in scikit-build, the /usr/bin/cmake3 executable is always found first before the cmake executable on the user's PATH that comes from the conda-forge cmake package. The cmake package doesn't install a cmake3 binary.

@henryiii suggested that we should first check for cmake and if it's sufficiently new use that, and otherwise fall back to cmake3. This will preserve compatibility with old RHEL setups where cmake is really old but cmake3 works.

Originally posted by @ngoldbaum in conda-forge/scikit-build-feedstock#78

@henryiii
Copy link
Contributor

Actually, I was thinking scikit-build-core; it's a little tricker in scikit-build, since we don't have the minimum version set were we can read it in the old system. Maybe we could either select cmake if it's >3, otherwise look for cmake3, or select the newest of the pair? I believe cmake is the official command, and cmake3 is only a RHEL addition since they wanted to have LTS support for CMake 2.8.

I'm not sure what our lowest supported version is (scikit-build-core is 3.15, but I think scikit-build currently supports a lot less, possibly 2.8).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants