debug build with pip?

[qnzhou]

Hi there, thanks for this great tool!

I am not able to figure out how to create a cmake debug build using pip.

export SKBUILD_CONFIGURE_OPTIONS="-DCMAKE_BUILD_TYPE:STRING=Debug"
SETUPTOOLS_ENABLE_FEATURES=legacy-editable pip install -e .

however, it does not work.

$ grep CMAKE_BUILD_TYPE _skbuild/*/cmake-build/CMakeCache.txt
CMAKE_BUILD_TYPE:STRING=Release

Any hints? Thanks!

[henryiii]

It looks like the logic is incorrect for passing this through properly. It was only designed for setup.py commands. :( I think

scikit-build/skbuild/setuptools_wrap.py

Lines 114 to 115 in 676e110

	if namespace.build_type is not None:
	_cmake_args.append("-DCMAKE_BUILD_TYPE:STRING=" + namespace.build_type)

needs to respect having it already set in the arguments, like

scikit-build/skbuild/setuptools_wrap.py

Lines 600 to 607 in 676e110

	# Select correct --config using final CMAKE_BUILD_TYPE
	for item in cmake_args[::-1]:
	if item.startswith("-DCMAKE_BUILD_TYPE"):
	_, config_type = item.split("=")
	break
	else:
	config_type = "Release"
	cmake_args.append("-DCMAKE_BUILD_TYPE:STRING=Release")

does.

PS: In scikit-build-core you can set this in toml or via -C (config-settings).

[qnzhou]

Thanks! I will try scikit-build-core again. I remember there was some missing feature (possibly related to editable debug build) that prevents me from migrating to it, but I will double check again! Thanks for confirming this bug!