Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser/page action assets aren't copied #1

Open
rosszurowski opened this issue Sep 9, 2016 · 1 comment
Open

Browser/page action assets aren't copied #1

rosszurowski opened this issue Sep 9, 2016 · 1 comment

Comments

@rosszurowski
Copy link

It looks like assets referenced in manifest.json for a browser_action aren't getting copied over into the build folder.

So for a manifest like:

"browser_action": {
  "default_title": "Extension",
  "default_icon": {
    "19": "assets/icons/action/19.png",
    "38": "assets/icons/action/38.png"
  }
}

The 19.png and 38.png files don't get copied anywhere.

Looking at the source, it looks like this'll be the case for page actions too.

Copying files is easy enough to work around, but it'd be great to have this as part of the default behaviour!

@rosszurowski
Copy link
Author

rosszurowski commented Sep 9, 2016

Ah, I see you've already noted this down in the "Future" section of the README.md:

allow to have "static" files which will be merged into build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant