Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

< and > symbols not handled correctly #7

Open
dkador opened this issue Jun 4, 2012 · 0 comments
Open

< and > symbols not handled correctly #7

dkador opened this issue Jun 4, 2012 · 0 comments

Comments

@dkador
Copy link

dkador commented Jun 4, 2012

First, thanks for writing this. Makes hipchat so much better to use. One problem I've noticed, though, is that messages that include what could be markup tags aren't handled correctly. Super easy to reproduce - just type a message like "". The official hipchat client renders this correctly. Adium with this message style does not - the message shows up as empty, presumably because the browser engine sees this and tries to render the tag.

I was able to "fix" this by going into Contents/Resources/Footer.html and commenting out the lines of code in scrubHTML() that unescape HTML entities. But obviously that breaks all the nice formatting of other HTML tags, which sucks. I've left things as originally written for now, but this would be a nice thing to have fixed. Hopefully there's a good way to fix this without having to resort to a whitelist of known HTML tags to escape. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant