Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overloads with explicit class loader to com.schibsted.spt.data.jslt.FunctionUtils #197

Open
ppalaga opened this issue Jun 3, 2021 · 1 comment · May be fixed by #198
Open

Add overloads with explicit class loader to com.schibsted.spt.data.jslt.FunctionUtils #197

ppalaga opened this issue Jun 3, 2021 · 1 comment · May be fixed by #198

Comments

@ppalaga
Copy link

ppalaga commented Jun 3, 2021

... and consider changing the existing FunctionUtils methods to use current thread's context class loader as a fallback. This is because in complex class loader environments (like Jboss Modules or Quarkus) the loader of the class calling FunctionUtils.wrapStaticMethod() may be unable to load the requested class. Current thread's context class loader is typically a good choice in situations like this one.

I could prepare a PR if this sounds good to you?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add overloads with explicit class loader to FunctionUtils ppalaga/jslt
1 participant
@ppalaga