Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description inconsistency in addressCountry property #3363

Open
miller79 opened this issue Aug 23, 2023 · 2 comments · May be fixed by #3364
Open

Description inconsistency in addressCountry property #3363

miller79 opened this issue Aug 23, 2023 · 2 comments · May be fixed by #3364
Labels
no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!).

Comments

@miller79
Copy link

miller79 commented Aug 23, 2023 •
edited

The description for the addressCountry property currently says "The country. For example, USA. You can also provide the two-letter ISO 3166-1 alpha-2 country code."

As you can see, the example is using ISO 3166-1 alpha-3 but it then says you can provide a ISO 3166-1 alpha-2 country code. This feels like it was more than likely a mistake and should have either all been the alpha-2 or all be alpha-3 or potentially support both.

The selection should be clearer and match the example.
@KalleOlaviNiemitalo
Copy link

Similar to #3310.

@miller79 miller79 linked a pull request Aug 23, 2023 that will close this issue
Open
@miller79 miller79 changed the title Description inconsistency in PostalAddress for addressCountry Description inconsistency in addressCountry property Aug 23, 2023
@github-actions GitHub Actions
Copy link

This issue is being nudged due to inactivity.

@github-actions github-actions bot added the no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated the example for addressCountry to be compliant with ISO-3166-1 alpha-2. miller79/schemaorg
2 participants
@miller79 @KalleOlaviNiemitalo