Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MediaObject does not allow Text for duration-property, but according to examples Text should be allowed #3021

Open
jaylinski opened this issue Dec 29, 2021 · 2 comments · May be fixed by #2996
Open

MediaObject does not allow Text for duration-property, but according to examples Text should be allowed #3021

jaylinski opened this issue Dec 29, 2021 · 2 comments · May be fixed by #2996
Labels
no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!).

Comments

@jaylinski
Copy link

As the example in MediaObject states, the duration-property can be a
Text and does not have to be a Duration-class:

{
  "@context": "https://schema.org",
  "@type": "AudioObject",
  "contentUrl": "http://media.freesound.org/data/0/previews/719__elmomo__12oclock_girona_preview.mp3",
  "description": "Recorded on a terrace of Girona a sunday morning",
  "duration": "T0M15S",
  "encodingFormat": "audio/mpeg",
  "name": "12oclock_girona.mp3"
}

https://schema.org/MediaObject

Maybe I'm missing something and the schema already allows a Text-value, but the main reason I'm opening this PR is issue spatie/schema-org#172.

This issue is fixed in PR #2996.
@jaylinski jaylinski linked a pull request Dec 29, 2021 that will close this issue
Open
@jaylinski jaylinski changed the title MediaObject does not allow Text for duration-property, but accordings to examples Text should be allowed MediaObject does not allow Text for duration-property, but according to examples Text should be allowed Dec 29, 2021
@github-actions
Copy link

This issue is being nudged due to inactivity.

@github-actions github-actions bot added the no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). label Mar 30, 2022
@jaylinski
Copy link
Author

This issue is still relevant. I'm just not sure how I can get anyone from the schemaorg-team involved...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow Text for duration-properties, fixes #3021 jaylinski/schemaorg
1 participant
@jaylinski