Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding objects to the scene breaks for some object types #565

Open
2 of 5 tasks
smlpt opened this issue Mar 7, 2024 · 4 comments · Fixed by #566
Open
2 of 5 tasks

Adding objects to the scene breaks for some object types #565

smlpt opened this issue Mar 7, 2024 · 4 comments · Fixed by #566
Labels

Comments

@smlpt
Copy link
Contributor

smlpt commented Mar 7, 2024

Several entries from the Add menu won't add objects to the scene, but instead show a warning message.
These include:

  • Compass:
  Invalid final parameter: private final float
  sc.iview.commands.add.AddOrientationCompass.axisLength
  Invalid final parameter: private final float
  sc.iview.commands.add.AddOrientationCompass.AXESBARRADlUS
  Invalid final parameter: private final org.joml.Vector3f
  sc.iview.commands.add.AddOrientationCompass.xColor
  Invalid final parameter: private final org.joml.Vector3f
  sc.iview.commands.add.AddOrientationCompass.yColor
  Invalid final parameter: private final
  sc.iview.commands.add.AddOrientationCompass.zColor
  • Label Image:
`currentImage` is required but unset.
  • Point Light:
The module "sc.iview.commands.add.AddPointLight" is invalid:
- Invalid final parameter: private final sc.iview.SciView
sc.iview.commands.add.AddPointLight.sciView
  • Protein from file:
`files` is required but unset.
  • Volume from ImageJ:
`image` is required but unset.
@smlpt smlpt added the bug label Mar 7, 2024
@kephale
Copy link
Member

kephale commented Mar 9, 2024

Add Proteins from File does not throw that error for me, but when I do add the PDBs to list and try to open them I get:

[ERROR] Command errored: Protein from files ...
java.lang.NoClassDefFoundError: javax/xml/bind/JAXBException
	at org.biojava.nbio.structure.io.PDBFileParser.pdb_CRYST1_Handler(PDBFileParser.java:1543)
	at org.biojava.nbio.structure.io.PDBFileParser.parsePDBFile(PDBFileParser.java:2694)
	at org.biojava.nbio.structure.io.PDBFileParser.parsePDBFile(PDBFileParser.java:2580)
	at org.biojava.nbio.structure.io.PDBFileReader.getStructure(PDBFileReader.java:140)
	at org.biojava.nbio.structure.io.LocalPDBDirectory.getStructure(LocalPDBDirectory.java:323)
	at org.biojava.nbio.structure.URLIdentifier.loadStructure(URLIdentifier.java:168)
	at org.biojava.nbio.structure.align.client.StructureName.loadStructure(StructureName.java:517)
	at org.biojava.nbio.structure.align.util.AtomCache.getStructure(AtomCache.java:503)
	at org.biojava.nbio.structure.align.util.AtomCache.getStructure(AtomCache.java:487)
	at org.biojava.nbio.structure.StructureIO.getStructure(StructureIO.java:97)
	at graphics.scenery.proteins.Protein$MyProtein.fromID(Protein.kt:29)
	at sc.iview.commands.add.AddProteinFromFiles.run(AddProteinFromFiles.kt:66)
	at org.scijava.module.ModuleRunner.run(ModuleRunner.java:165)
	at org.scijava.module.ModuleRunner.call(ModuleRunner.java:125)
	at org.scijava.module.ModuleRunner.call(ModuleRunner.java:64)
	at org.scijava.thread.DefaultThreadService.lambda$wrap$2(DefaultThreadService.java:247)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: java.lang.ClassNotFoundException: javax.xml.bind.JAXBException
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
	... 20 more

@skalarproduktraum the stack trace on this runs through scenery and the error looks like a missing dependency?

Is that this thing? https://stackoverflow.com/questions/75936491/what-are-the-jaxb-jar-files-to-be-used-with-java-17-project

@kephale
Copy link
Member

kephale commented Mar 9, 2024

For Volume from ImageJ I get:

image

even through the T1 head sample is already open.

@kephale
Copy link
Member

kephale commented Mar 9, 2024

I noticed this UI issue with Add Proteins from Files:

image

but it should show these extensions: pdb/mmtf/cif

@kephale kephale reopened this Mar 9, 2024
@kephale
Copy link
Member

kephale commented Mar 9, 2024

The remaining issues are:

  • harvesting input Dataset isn't working
  • javax/xml/bind/JAXBException when opening pdbs from file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants