Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Devices (iPhone SE) Library won't add space for grabber #620

Open
mihaicris-adoreme opened this issue Feb 19, 2024 · 3 comments
Open

Comments

@mihaicris-adoreme
Copy link

mihaicris-adoreme commented Feb 19, 2024

Description

Small Devices (iPhone SE) Library wont add space for grabber (grabber hidden or shown - the same)

Expected behavior

There is space for grabber before content

Actual behavior

Library wont add space for grabber

Steps to reproduce

See Screenshots (iPhone 15 Pro vs iPhone SE Gen 3)

How do you display panel(s)?

  • Present modally

How many panels do you displays?

  • 1

Environment

Library version
2.8.1

Installation method

  • Swift Package Manager

iOS version(s)

17.2

Xcode version
15.2

image_720
image_720-1

@mihaicris-adoreme mihaicris-adoreme changed the title Small Devices (iPhone SE) Library wont add space for grabber Small Devices (iPhone SE) Library won't add space for grabber Feb 19, 2024
@scenee
Copy link
Owner

scenee commented Feb 23, 2024

I tried to reproduce this issue with 'Show Panel in Sheet Modal' use case in the Samples app, but I couldn't.
It depends on your FloatingPanelLayout configuration, but I suppose it's caused by safe area behavior of the panel content. If the top anchor of 'Earning Loyalty Points' is constrained to a safeAreaLayoutGuide, I would like you to try to replace it with a constraint to a parent view layout guide.

@mihaicris-adoreme
Copy link
Author

mihaicris-adoreme commented Feb 23, 2024

I added a sample project here:
https://github.com/mihaicris-adoreme/FloatingPanel/tree/master/Examples/Bug

Run with iPhone SE and iPhone 15 Pro

@mihaicris-adoreme
Copy link
Author

I think it is the same as #454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants