Add ApplyUsingTree that represents context parameter application #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanishiking
force-pushed
the
add-apply-using-tree
branch
from
5d4965f
to
0c094cb
Compare
|
FYI @bishabosha |
tgodzik
reviewed
Sep 6, 2021
| @@ -1038,6 +1038,7 @@ message Tree { | |||
| OriginalTree original_tree = 6; | |||
| SelectTree select_tree = 7; | |||
| TypeApplyTree type_apply_tree = 8; | |||
| ApllyUsingTree apply_using_tree = 9; | |||
There was a problem hiding this comment.
Suggested change
| ApllyUsingTree apply_using_tree = 9; | |
| ApllyContextTree apply_using_tree = 9; |
maybe? Using feels a bit too general. What do you think @olafurpg ?
kitbellew
reviewed
Jan 1, 2022
| @@ -1038,6 +1038,7 @@ message Tree { | |||
| OriginalTree original_tree = 6; | |||
| SelectTree select_tree = 7; | |||
| TypeApplyTree type_apply_tree = 8; | |||
| ApllyUsingTree apply_using_tree = 9; | |||
There was a problem hiding this comment.
didn't read the entire pr, but isn't there a typo here?
|
Closing as I don't have a plan to go with this change in the neqr future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2460
Added Scala's
Syntheticpart: