Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor existing Gitlab required reviewers option to support latest API implementation #2794

Open
dkichler opened this issue Nov 24, 2022 · 1 comment · May be fixed by #3014
Open

Refactor existing Gitlab required reviewers option to support latest API implementation #2794

dkichler opened this issue Nov 24, 2022 · 1 comment · May be fixed by #3014
Labels
cat:forge help wanted Extra attention is needed refactoring

Comments

@dkichler
Copy link
Contributor

The existing Gitlab required reveiwers feature is based on a Gitlab API endpoint that has been deprecated and will be removed in a future release: https://docs.gitlab.com/ee/api/merge_request_approvals.html#change-approval-configuration-deprecated

Refactor this option/feature to use the replacement API from Gitlab to achieve the same effect. (https://docs.gitlab.com/ee/api/merge_request_approvals.html#create-merge-request-level-rule)
@exoego exoego added refactoring help wanted Extra attention is needed labels Nov 24, 2022
@endertunc
Copy link

I can pick this up if no one stared already.

@endertunc endertunc linked a pull request Mar 19, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cat:forge help wanted Extra attention is needed refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support merge request level approval rules to set required approvals #2794 endertunc/scala-steward
4 participants
@exoego @fthomas @dkichler @endertunc