Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala-xml no longer part of core library in Scala-3... #467

Open
DavidGoodenough opened this issue Jun 5, 2022 · 2 comments
Open

scala-xml no longer part of core library in Scala-3... #467

DavidGoodenough opened this issue Jun 5, 2022 · 2 comments

Comments

@DavidGoodenough
Copy link

but it is excluded by the includeScala=false directive as its file name starts with "scala-".

Unfortunately once excluded there appears to be no way to override the exclusion. So the logic that decided which .jar files to include when this option is used needs to be updated to use a better way of determining whether to include .jar content.

@TimBloy
Copy link

TimBloy commented Apr 2, 2024

Hello, we've come across the same issue specifically for scala-xml. It appears the below check is flawed.

We're on Scala 3.3.1, so we would pass the >=2 check put fail the >=13 for the minor version.

val scalaLibraries = {
val scalaVersionParts = VersionNumber(ao.scalaVersion)
val isScala213AndLater =
scalaVersionParts.numbers.length >= 2 && scalaVersionParts._1.get >= 2 && scalaVersionParts._2.get >= 13
if (isScala213AndLater) scala213AndLaterLibraries else scalaPre213Libraries
}

As more users take on Scala 3.3 this will likely become more of an issue.

@mzuehlke
Copy link

mzuehlke commented Apr 2, 2024

As @TimBloy mentions the logic seems to predate Scala 3.
The Scala 3 artifacts have even different names ("scala3-compiler" and "scala3-library")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants