Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Name Filtering causing False Positives #460

Open
JAlexoid opened this issue Feb 1, 2022 · 3 comments
Open

File Name Filtering causing False Positives #460

JAlexoid opened this issue Feb 1, 2022 · 3 comments

Comments

@JAlexoid
Copy link

JAlexoid commented Feb 1, 2022

Filtering contents of UberJar by filename causes false positives.

As an example, if the I were to filter out all fasterxml jars from uber jar I would add a filter for startsWith("jackson"), but that yields false positives. As an example Jackson Databind OpenAPI library.

Without artifact data access this also yields unpredictable results, when upgrades happen.

@eed3si9n
Copy link
Member

eed3si9n commented Feb 2, 2022

Thanks for the report. Could you provide reproduction steps so we can reproduce your problem on our computers?

@JAlexoid
Copy link
Author

JAlexoid commented Feb 3, 2022

Please see this repo https://github.com/JAlexoid/sample-sbt-assembly-failure

When you run sbt clean assembly the Uber jar excludes "org.openapitools" % "jackson-databind-nullable" as well.
I need to filter out only FasterXML Jackson libraries(all of them), but OpenAPI libraries should be preserved.

The filtering happens on the artifactId, rather than on group and artifact IDs.

This is not detectable until runtime.

@JAlexoid
Copy link
Author

JAlexoid commented Feb 3, 2022

SBT Assembly needs ability to filter on dependency metadata, not just filename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants