Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Client can be banned with SteamID pending #948

Open
Rushaway opened this issue Feb 13, 2024 · 0 comments
Open

bug: Client can be banned with SteamID pending #948

Rushaway opened this issue Feb 13, 2024 · 0 comments

Comments

@Rushaway
Copy link
Contributor

Rushaway commented Feb 13, 2024

What are the steps to reproduce this issue?

  1. Connect a target with a SteamID Pending status
  2. Ban him

What happens?

An admin banned a player with SteamID Pending, resulting in a empty ban inserted into DB.

What were you expecting to happen?

Don't ban the player, or get the steamid as backend verification of steam server.

Any logs, error output, etc.?

[sourcebans/sbpp_main.smx] "Kayn<1683><[U:1:66482081]><>" banned "May God bless you [Ronaldo]<1792><STEAM_ID_PENDING><>" (minutes: 4320) (reason: Bhop Hack).

Any other comments?

This is caused by OnClientAuthorized considering these as valid values
https://github.com/alliedmodders/sourcemod/blob/master/plugins/include/clients.inc#L51-#L55

What versions of software are you using?

Operating System: ubuntu 20.04
SourceBans++ Version: PHP 8.1 branch, last commit
SourceMod Version: 1.12
MetaMod Version: 1.12

@Rushaway Rushaway reopened this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant