Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in the tag name #372

Open
SolunarNexus opened this issue Feb 25, 2024 · 1 comment
Open

Typo in the tag name #372

SolunarNexus opened this issue Feb 25, 2024 · 1 comment

Comments

@SolunarNexus
Copy link

I found a typo during syntactic testing in the file syntactic_tests.v3.4.0/syntactic/21104/21104-fail-01-13-sev2-l3v1.xml on line 33 where element name is modiferSpeciesReference (missing 'i', correct modifierSpeciesReference).

@luciansmith luciansmith transferred this issue from sbmlteam/sbml-test-suite May 15, 2024
@luciansmith
Copy link
Member

The validation rule these models are supposed to be checking is if there are incorrect elements as children in the listOfReactants, so technically, both 'modifierSpeciesReference' objects and 'modiferSpeciesReference' objects are both illegal. However, it's a stronger test to check correctly spelled things in the wrong place than incorrectly spelled things in the wrong place, so I've gone ahead and put in a pull request for the change. Thank you for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants