-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit validation with distrib uniform not working #365
Comments
looks like unit validation cannot know what the result of a function defined in the distrib package is. I am not aware of any plugin system in libSBML that allows packages to extend unit validation. Will have to discuss with @skeating |
Thanks. |
it feels like the proper thing to do would be to have the distrib plugin provide information about the csymbols and the unit input/output relationship. adding dimensionless like in your example would prove troublesome in more involved expressions, potentially. |
Hi all, |
Hi all,
I have an SBML model with an initial assignment from a uniform distribution (model attached).
spt_random.zip
Despite having set the units on the distributions I get a unit validation warning.
It seems like the unit validation does not work with the distributions.
Here the basic structure. An initial assignment from a
uniform(0 dimensionless, 1 dimensionless)
to a parameter which is dimensionless. I.e. the distribution and the parameter are compatible, but still get the warning below.Probably similar things happen with the other csymbol distributions.
Best Matthias
The text was updated successfully, but these errors were encountered: