Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the library to [lib]combine #47

Open
agarny opened this issue Jan 6, 2022 · 2 comments · May be fixed by #48
Open

Rename the library to [lib]combine #47

agarny opened this issue Jan 6, 2022 · 2 comments · May be fixed by #48

Comments

@agarny
Copy link
Contributor

agarny commented Jan 6, 2022

With [lib]Combine, a CMake file called [lib]Combine-static-config.cmake gets generated. Such a CMake file cannot be found on a case-sensitive system (since that kind of filename should be all lower case). Instead, a CMake file called [lib]combine-static-config.cmake should be generated, hence the suggestion to rename the library to [lib]combine, not least so that it's consistent with libSBML, for instance.
@agarny agarny linked a pull request Jan 6, 2022 that will close this issue
Open
@fbergmann
Copy link
Member

The problem that i see, is with this change, all packages that ever used libCombine will have to change. So far they would have had a fallback statement using the CONFIGS flag on case sensitive filesystems. But with the PR the number of variables to test would have to be doubled (checking for [lib][c|C]ombine), to test. Here is how other projects were importing in the past:

find_package(${COMBINE_LIBRARY_NAME} CONFIG QUIET)

if (NOT ${COMBINE_LIBRARY_NAME}_FOUND)
  find_package(${COMBINE_LIBRARY_NAME} CONFIG QUIET
  CONFIGS ${COMBINE_LIBRARY_NAME}-config.cmake
  PATHS ...
  )
endif()

@agarny
Copy link
Contributor Author

agarny commented Jan 10, 2022

Fair enough. I have my own fork of the library, so I am fine. (Feel free to close this issue and the corresponding PR.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renamed the library to [lib]combine opencor/libCombine
2 participants
@agarny @fbergmann