Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using ServiceLoader #6

Open
fvasco opened this issue Oct 22, 2018 · 0 comments
Open

Consider using ServiceLoader #6

fvasco opened this issue Oct 22, 2018 · 0 comments

Comments

@fvasco
Copy link

fvasco commented Oct 22, 2018

Consider using ServiceLoader instead of reflection.
ServiceLoader is a standard way for pluggable component, so you can remove the home made Hidden annotation.

petscii-bbs/src/main/java/eu/sblendorio/bbs/core/BBServer.java

Line 103 in 0a9546a

for (Class<? extends PetsciiThread> elem: new LinkedList<>(new Reflections(defaultString(packageName)).getSubTypesOf(PetsciiThread.class)))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fvasco