Skip to content

NeuroMF bug #99

Open
monkey0head opened this issue Feb 16, 2022 · 1 comment
Open

NeuroMF bug #99

monkey0head opened this issue Feb 16, 2022 · 1 comment
Assignees
Labels
bug Something isn't working high priority Should be done in the first place

Comments

@monkey0head
Copy link
Contributor

monkey0head commented Feb 16, 2022

After indexing change negative generation for NeuroMF got a bug.
Before: negatives were sampled from [0, num_items) uniform distribution; for now it is from [0, max_item + 1) distribution.
Ids were consecutive before and now they are not, so we can sample absent ids, which can break a training or make it less efficient.
Here:

    def _get_neg_batch(self, batch: Tensor) -> Tensor:
        negative_items = torch.randint(
            0,
            self._item_dim,
            (batch.shape[0] * self.count_negative_sample,),
        )
        return negative_items
@monkey0head monkey0head added the bug Something isn't working label Feb 16, 2022
@monkey0head
Copy link
Contributor Author

  • probably affects slim, admm slim, lightFM, multVAE

@monkey0head monkey0head added the high priority Should be done in the first place label Apr 5, 2022
@monkey0head monkey0head self-assigned this Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working high priority Should be done in the first place
Projects
None yet
Development

No branches or pull requests

1 participant