Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the title has an apostrophe it instead shows "&#x27" #58

Open
Spencer-Villarreal opened this issue Feb 17, 2022 · 2 comments · May be fixed by #71
Open

If the title has an apostrophe it instead shows "&#x27" #58

Spencer-Villarreal opened this issue Feb 17, 2022 · 2 comments · May be fixed by #71

Comments

@Spencer-Villarreal
Copy link

When I am using your pod to fetch the OG tags from a news article that has an apostrophe it shows an error with your method.

Version: 1.4.1
Used cocapods to install
Xcode version: 13.2.1
Device: iPhone 12 iOS 15.1

----- Example 1 -----
Should receive:
Jim Simons' RenTech fund nearly doubled its AMC stake

What I receive when using your pod:
Jim Simons' RenTech fund nearly doubled its AMC stake

https://markets.businessinsider.com/news/stocks/jim-simons-renaissance-technologies-rentech-amc-entertainment-gamestop-tesla-stock-2022-2?amp

----- Example 2 -----
Should receive:
Today's Stock Market News & Events: 12/8/2021

What I receive when using your pod:
Today's Stock Market News & Events: 12/8/2021

https://www.schaeffersresearch.com/content/news/2021/12/08/todays-stock-market-news-events-12-8-2021

----- Example 3 -----
Should receive:
Interest rate hike needed 'shortly' after March

What I receive when using your pod:
Interest rate hike needed 'shortly' after March

https://www.marketwatch.com/story/interest-rate-hike-needed-shortly-after-march-end-to-asset-purchases-feds-waller-says-11639764021

@Spencer-Villarreal
Copy link
Author

Wow, Github automatically changes the Unicode to the apostrophe. My question may look weird by the main thing is that the apostrophes are still in Unicode

@khanlou
Copy link
Contributor

khanlou commented Aug 30, 2022

I was noticing this too — I think this library should probably be the one to handle this conversion, rather than putting it on every caller

@martinmaly21 martinmaly21 linked a pull request Mar 4, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants