Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass prediction fails for deep space objects #98

Open
ajwolfram opened this issue Sep 8, 2020 · 2 comments
Open

Pass prediction fails for deep space objects #98

ajwolfram opened this issue Sep 8, 2020 · 2 comments
Labels

Comments

@ajwolfram
Copy link

Orbit prediction on deep space objects (orbital period > 225 minutes) almost always fails due to the assert statement in _find_aos in the base predictor. The assert statement requires the starting elevation to be less than zero, however, for the deep space objects I'm testing, the start elevation that is calculated in _find_aos seems to almost always be between 0 and 1 radians. Thus, get_next_pass and passes_over almost always fail for deep space objects. How can I resolve this? Is this an issue with the orbit step size?

@astrojuanlu
Copy link
Contributor

Hi @ajwolfram , thanks for your interest in orbit-predictor! We have never tried to use it for deep space objects, so it's very likely that there are bugs. Can you paste an excerpt of your code so we can reproduce?

@ajwolfram
Copy link
Author

Hi @astrojuanlu! Here's the offending code:

import datetime

from orbit_predictor.sources import get_predictor_from_tle_lines
from orbit_predictor.locations import Location

# MAQSAT/ARIANE 5
predictor = get_predictor_from_tle_lines(
    ('1 25503U 98059A   20252.20879031 -.00000054  00000-0 -24376-2 0  9992',
     '2 25503   7.0466 262.2333 7006939 166.3646 232.7881  2.24574052179590'))

loc = Location('seattle', 47.6062, 122.3321, 53.34)
next_passes = iter(predictor.passes_over(loc, datetime.datetime.utcnow()))
for i in range(50):
    next(next_passes)

arihantdaga added a commit to redkibble/orbit-predictor that referenced this issue Sep 13, 2022
Attempring to fix this issue, by removing assertion, it may not be correct though
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants