Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pip-resolver-benchmarks and Pip code to create "real world" resolvelib tests? #151

Open
notatallshaw opened this issue Feb 10, 2024 · 2 comments

Comments

@notatallshaw
Copy link
Contributor

notatallshaw commented Feb 10, 2024

I have an idea to use pip-resolver-benchmarks and Pip code to create tests that could exactly model real world scenarios to test resolvelib.

In particular I would want to add test cases from #134 where they are represented by a json, then as part of the test prep get the pip-resolver-benchmarks code to build the wheels, and then have enough Pip code for this to fail in the current resolvelib.

While I would try and keep it minimal as possible it probably would be quite a lot of code from both pip-resolver-benchmarks and Pip to get this working. So I understand if it's not acceptable.

In particular @pradyunsg do you have any thoughts or objections?

@uranusjr
Copy link
Member

Sounds like a good idea to me. The suite already contains some real-world cases I stole from other resolvers before pip started using resolvelib, and now pip has its own real-world cases, it makes sense to add them here.

@notatallshaw
Copy link
Contributor Author

notatallshaw commented Mar 26, 2024

I've pivoted a little on this, and am now focusing on packse tests, once I have packse tests working for pip (pypa/pip#12580) I am going to see if I can use the pip-resolver-benchmarks collection tool to make jsons that I can transform into packse jsons that could be used for packse to make "real world" tests for either pip or resolvelib or both. But I may pivot again, depending how packse and pip-resolver-benchmarks update over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants