Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve order of hashes or sort them on write in requirements file #358

Open
matejsp opened this issue Jan 7, 2023 · 0 comments
Open

Comments

@matejsp
Copy link

matejsp commented Jan 7, 2023

As per reported issue in pipenv pypa/pipenv#5552 there is issue that requirementslib stores hashes in non deterministic order. They should be stored in alphabetic order or in preserve order based on insertion.

Method add_hashes produces a set with no order guarantees.
https://github.com/sarugaku/requirementslib/blob/main/src/requirementslib/models/requirements.py#L2427

@matteius already prepared a pull request that sorts hashes on write.
#357

@matejsp matejsp changed the title Sort hashes deterministicly Preserve order of hashes or sort them on write in requirements file Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant