Firefox 55+ Issues

[maximilianoe]

I'm using Firefox 55.0b1 Beta and found a couple of issues with this theme. Obviously I don't expect to get support for Beta versions, just wanted to give a heads up for future development.

1. Minimize/Maximize/Close Buttons missing Fixed with v1.11.0

2. The notification blinking only partially covers the tab

3. The reload button is not Edge themed Fixed with v1.11.0

4. When manually enabling the new Photon design (coming in Firefox 57+) via browser.photon.structure.enabled this happens:

5. Dropdown arrows missing Caused by OverlayScrollbars
6. Bookmark star missing - might be caused by Firefox 56
7. Search provider selection below URL Searchbar Popup is not themed Fixed with v1.11.0

And a general "issue" but I'm sure you're aware, some elements have not been themed yet.
Library (History, Downloads, Bookmarks):

Download file prompt:

Master password prompt:

Thank you for your work/theme, I just recently found it and really like it.

[sapierens]

Thanks for reporting!
I don't plan on styling the additional windows you provided, because arguably they're not visible very often. I did however attempt to style the password prompt dialog once, but I couldn't find a way to fully style it, so I dropped the idea.

As for 4. - so far I've read that with Firefox 57, users won't be able to style UI anymore. So I won't be adding support for the new design.

[TheFreeWindows]

I'm very sorry to learn that Firefox is going to forbid UI customizations. In my opinion the flexibility of this browser is its main advantage. And I'm also sorry that your fine work with this theme perhaps (we are not sure yet) will stop too. However, until that happens, and hoping it won't happen, I'd like to present your theme to my visitors at TheFreeWindows.com I have a negative (the only one) remark that I'm going to make, and I wanted to have your word on that in order to add it to my review. Trying the theme with the popup styling I found out that using the keyboard's arrow keys I could not see where I happened to be in the menu, what option was selected. Using the mouse, hovering above the several choices was reflected in the normal change of background. Thus, I was forced to install the theme excluding the popup menu styling. Perhaps you are aware of that, which is the reason of offering a no-popup version of the theme. Is there going to be any fix of that?

Congratulations again!

George
www.thefreewindows.com

[sapierens]

Thanks and a great catch!
This is the first time anyone has reported the bug. And since I'm not using menus in conjunction with arrow keys, I have never stumbled upon it myself.
I'll get it fixed for the next release, which will most likely be around the release of Firefox 55 (~August 8th).

The no-popup version is available because the first versions of this theme didn't offer any popup styling. So I'm leaving it up for people who prefer the theme without styled menus.

[maximilianoe]

I've tested the newest dark version from the development branch and noticed some additional issues (Issue 1 & 3 have been fixed).

5. Dropdown arrows missing
6. Bookmark star missing
7. Search provider selection below URL Searchbar Popup is not themed

[sapierens]

Are you on Firefox 56 beta right now?
I can't reproduce any of the remaining issues you reported on Firefox 55 release.

7. Search provider selection below URL Searchbar Popup is not themed

I disabled the styling for the search settings on the search-bar popup because it was contrasting too much with the unthemed search-bar popup.

[maximilianoe]

May I suggest theming the url-bar popup so you can turn the search-bar theme back on?
This works for me:

#urlbar
{
  opacity: 1 !important;
}

#urlbar:hover
{
  opacity: 0.91 !important;
}

#urlbar[focused="true"]
{
  opacity: 0.98 !important;
}

#PopupAutoCompleteRichResult richlistitem,#PopupAutoCompleteRichResult richlistitem *
{
  color: white !important;
  background: #383838;
}

Issue 5 was happening on Firefox 55 as well with the lastest stable version from the master branch. However issue 6 might be caused by Firefox 56 Beta, only noticed it after upgrading.

[sapierens]

Can you provide an example for 5? Where exactly are dropdown arrows missing.

I might add url-bar popup theming as a seperate option on userstyles.

[maximilianoe]

After some testing it turns out OverlayScrollbars causes the missing dropdown arrows.

I might add url-bar popup theming as a seperate option on userstyles.

That would be great 👍

[maximilianoe]

I have edited the start post to reflect the changes.

This theme nicely plays together with Firefox Edge Dark by theming all the "about" pages.
Just as a suggestion, maybe you could integrate/copy some aspects of it for the next version.

[sapierens]

I installed Firefox 56.0b1 and issues 2 and 6 were not present for me. What OS are you on? Are you sure there's no other theme/extension that could be messing with the style?

This theme nicely plays together with Firefox Edge Dark by theming all the "about" pages.
Just as a suggestion, maybe you could integrate/copy some aspects of it for the next version.

Since Firefox 56 is the last version to support my style, I don't really plan on adding any big changes.

[crapier]

With Firefox 57 out on nightly and developer channels I was sad to here that you aren't going to update for them. You won't consider it even though you can still manually apply the theme via the userChrome.css. On 57 I did some minor testing to see if it was usable and it looked to be partially working, but broken in some areas.

Partially working (some misalignment visible with the new tab button, minimize, maximize, etc. and the forward and back buttons seem oversized)

There were still the original number 4 issue, and a few other new unthemed areas.

Either way thanks for the theme while it was usable, I very much enjoyed it.