Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tvOS Support #51

Open
JaydenIrwin opened this issue Sep 22, 2018 · 7 comments
Open

tvOS Support #51

JaydenIrwin opened this issue Sep 22, 2018 · 7 comments

Comments

@JaydenIrwin
Copy link

Would it be possible to add tvOS support?

@saoudrizwan
Copy link
Owner

tvOS, watchOS, and macOS support is on the roadmap :^)

@hemangshah
Copy link

watchOS++

@mrgrauel
Copy link

@saoudrizwan when do you plan to add support?

@craigrouse
Copy link

craigrouse commented Apr 29, 2019

@saoudrizwan As far as I can tell at first glance, the only things currently blocking tvOS and watchOS support are the helper functions for volumeAvailableCapacityForImportantUsage and volumeAvailableCapacityForOpportunisticUsage. Removing these allows Disk to compile successfully for watchOS and tvOS. Have I missed anything? Assuming not, I will gladly work on a PR to allow it to compile for all platforms, while retaining this important functionality for iOS.

Just wondering if you had anything else in mind that would potentially block this from working on tvOS/watchOS? Thanks, Craig.

Edit: I see UIKit is used also, which stops it working on macOS, but this is easily solved too.

@hemangshah
Copy link

@craigrouse - I think, this would be great! Didn't know if that would be really easy to handle? I hope @saoudrizwan will take this forward from here with you.

@craigrouse
Copy link

@hemangshah @mrgrauel @JaydenIrwin @saoudrizwan

I have added support for tvOS, macOS and watchOS on my fork: https://github.com/craigrouse/Disk/tree/platform-support

I'm in the process of updating the README to take account of some of the differences by platform (everything pretty much behaves the same, except tvOS, where I have removed the possibility to use the documents directory and application support, since these aren't really supported on tvOS). Be aware that on tvOS, the caches directory could be purged by the OS at any time when your app is closed, if the device is running low on space (see https://developer.apple.com/library/archive/documentation/General/Conceptual/AppleTV_PG/index.html#//apple_ref/doc/uid/TP40015241-CH12-SW5).

Feedback welcome! I have built support for all platforms into a single scheme, so when you complile, you can just select the device you want to build against, and the appropriate framework will be built for that platform. This works nicely with Carthage, too.

When I've finished the README, I will create a PR.

@craigrouse
Copy link

PR now opened: #72

Has anyone tried my updates yet? I look forward to your comments :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants