You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Firstly, thanks very much for this implementation. It has really helped me understand PSOLA!
However, I found a bug in the windowing. It is best explained by this diagram:
The issue is due to the windowing being incorrect for all pitch ratios lower than 1.
In this case, the peaks array must be used to calculate windowing, requiring different math.
The text was updated successfully, but these errors were encountered:
MysteryPancake
changed the title
Windowing bug for pitch ratios less than 1
Incorrect windowing calculations for pitch ratios less than 1
Aug 24, 2020
MysteryPancake
changed the title
Incorrect windowing calculations for pitch ratios less than 1
Incorrect windowing for pitch ratios less than 1
Aug 24, 2020
Hello!
Firstly, thanks very much for this implementation. It has really helped me understand PSOLA!
However, I found a bug in the windowing. It is best explained by this diagram:
The issue is due to the windowing being incorrect for all pitch ratios lower than 1.
In this case, the
peaks
array must be used to calculate windowing, requiring different math.I've put a bit more explanation on Stack Exchange.
The text was updated successfully, but these errors were encountered: