Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect windowing for pitch ratios less than 1 #3

Open
MysteryPancake opened this issue Aug 24, 2020 · 0 comments
Open

Incorrect windowing for pitch ratios less than 1 #3

MysteryPancake opened this issue Aug 24, 2020 · 0 comments

Comments

@MysteryPancake
Copy link

MysteryPancake commented Aug 24, 2020

Hello!

Firstly, thanks very much for this implementation. It has really helped me understand PSOLA!

However, I found a bug in the windowing. It is best explained by this diagram:
useddiagram

The issue is due to the windowing being incorrect for all pitch ratios lower than 1.
In this case, the peaks array must be used to calculate windowing, requiring different math.

I've put a bit more explanation on Stack Exchange.

@MysteryPancake MysteryPancake changed the title Windowing bug for pitch ratios less than 1 Incorrect windowing calculations for pitch ratios less than 1 Aug 24, 2020
@MysteryPancake MysteryPancake changed the title Incorrect windowing calculations for pitch ratios less than 1 Incorrect windowing for pitch ratios less than 1 Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant