Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request dot scale parameter for Clustered_DotPlot #129

Open
Evenlyeven opened this issue Sep 22, 2023 · 3 comments
Open

Request dot scale parameter for Clustered_DotPlot #129

Evenlyeven opened this issue Sep 22, 2023 · 3 comments
Assignees
Labels
enhancement Enhance existing function/feature

Comments

@Evenlyeven
Copy link

Thank you for developing this package to make my life easier!

I was wondering if a dot scale parameter can be added to Clustered_DotPlot function. In DotPlot_scCustom function, which is ggplot2 based, the dot scale can be changed by using dot.scale from Seurat. But in Clustered_DotPlot, which is Complexheatmap based, I was not be able to change the dot scale. It would be great if you could add a dot scale feature to it. I would appreciate it if you could let me know how to change the dot scale too.

Thank you in advance!

@samuel-marsh
Copy link
Owner

Hi @Evenlyeven,

Thanks for kind words! Let me take look at code and get back to you. I agree that is potentially useful parameter to add.

Best,
Sam

@samuel-marsh samuel-marsh self-assigned this Sep 28, 2023
@samuel-marsh samuel-marsh added the enhancement Enhance existing function/feature label Sep 28, 2023
@samuel-marsh
Copy link
Owner

Hi @Evenlyeven

Just wanted to give you an update. I have figured out how we can set new sizes for the points however, no trying to solve how to automate spacing the legend so that legend dots don't overlap each other and so that legend text is still aligned correctly. Hopefully can get fix pushed sometime next week.

Best,
Sam

@samuel-marsh
Copy link
Owner

Hi @Evenlyeven,

Still working on this issue. Just wanted to give you update and let you know that currently my focus is ensuring the package is ready to send v2.0.0 to CRAN this weekend to match the full release of Seurat V5. I will continue to work on this but will be part of post v2.0.0 plans.

Best,
Sam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance existing function/feature
Projects
None yet
Development

No branches or pull requests

2 participants