Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility of QsQuery with actix_web Query caused by private tuple field #85

Open
Adhalianna opened this issue Jul 7, 2023 · 2 comments

Comments

@Adhalianna
Copy link

I have just attempted to replace actix's Query with QsQuery but I had some problems. Query has its field public which makes constructing it, for example within tests, possible whereas QsQuery cannot be constructed without taking in the whole request with from_request.

@Adhalianna
Copy link
Author

I have quickly checked and it seems that Query has had its field public at least since actix_web version 2.0.0, version 1.0.0 has it private.

@samscott89
Copy link
Owner

Hey @Adhalianna

Could you share a little more about the use case? Where would you want to access the QsQuery rather than the inner type, if not from the request object?

If possible, I would prefer to keep the inner type private, in case we want to extend it to include more fields in the future. But happy to make the change if there's no good alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants