Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation gaps #71

Open
andrewbaxter opened this issue Nov 14, 2022 · 1 comment
Open

Documentation gaps #71

andrewbaxter opened this issue Nov 14, 2022 · 1 comment

Comments

@andrewbaxter
Copy link

The docs say this support enums, but how are enums supported? I didn't see any information about that in qs either, and (typescript) handles enums quite differently than rust does so I'm not sure it would be a model. Having an example of how they serialize would be very useful.

Additionally, the readme says

serde_urlencoded, which should be preferred over this crate

Why?

Reading that I think this project must have significant issues that make it only worth using when you have this specific use case, but even with this use case I'm not particularly inclined to working around bugs, etc.

@andrewbaxter
Copy link
Author

andrewbaxter commented Nov 14, 2022

After looking at the tests, it looks like 3 enum modes are supported

  • Normal (external tagged)
  • Untagged
  • Tagged adjacent
  • Internal tagged enums are not supported?

How does untagged work? The test has e=true deserialize as a string true instead of bool true which seems like the exact opposite of what one would normally expect.

sbihel added a commit to sbihel/serde_qs that referenced this issue Jun 12, 2023
sbihel added a commit to sbihel/serde_qs that referenced this issue Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant